-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Instant Apply -> respect proxy's /models #2513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR enables dynamic model selection for instant apply operations by integrating the ProxyModelsService, which fetches model configurations from a remote endpoint. The change is gated behind the experimental configuration flag UseProxyModelsServiceForInstantApply to allow gradual rollout and testing. When enabled, both instant apply endpoints will use models fetched from the proxy models service instead of the statically configured model names.
Key Changes
- Added
IProxyModelsServicedependency injection to bothProxy4oEndpointandProxyInstantApplyShortEndpointconstructors - Implemented conditional model selection logic that checks the experimental flag and falls back to existing configuration-based model selection when disabled or when no models are available
- Introduced new configuration key
UseProxyModelsServiceForInstantApplyin theTeamInternalnamespace to control the feature rollout
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/platform/configuration/common/configurationService.ts | Added experimental configuration flag UseProxyModelsServiceForInstantApply to gate the new dynamic model selection behavior |
| src/platform/endpoint/node/proxyInstantApplyShortEndpoint.ts | Integrated ProxyModelsService with conditional model selection logic, falling back to InstantApplyShortModelName config or SHORT_INSTANT_APPLY constant |
| src/platform/endpoint/node/proxy4oEndpoint.ts | Integrated ProxyModelsService with conditional model selection logic, falling back to InstantApplyModelName config or GPT4OPROXY constant |
Enables dynamic model selection for instant apply operations through the ProxyModelsService, gated behind an experimental configuration flag.