Skip to content

Conversation

@24anisha
Copy link
Contributor

@24anisha 24anisha commented Dec 9, 2025

Enables dynamic model selection for instant apply operations through the ProxyModelsService, gated behind an experimental configuration flag.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enables dynamic model selection for instant apply operations by integrating the ProxyModelsService, which fetches model configurations from a remote endpoint. The change is gated behind the experimental configuration flag UseProxyModelsServiceForInstantApply to allow gradual rollout and testing. When enabled, both instant apply endpoints will use models fetched from the proxy models service instead of the statically configured model names.

Key Changes

  • Added IProxyModelsService dependency injection to both Proxy4oEndpoint and ProxyInstantApplyShortEndpoint constructors
  • Implemented conditional model selection logic that checks the experimental flag and falls back to existing configuration-based model selection when disabled or when no models are available
  • Introduced new configuration key UseProxyModelsServiceForInstantApply in the TeamInternal namespace to control the feature rollout

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
src/platform/configuration/common/configurationService.ts Added experimental configuration flag UseProxyModelsServiceForInstantApply to gate the new dynamic model selection behavior
src/platform/endpoint/node/proxyInstantApplyShortEndpoint.ts Integrated ProxyModelsService with conditional model selection logic, falling back to InstantApplyShortModelName config or SHORT_INSTANT_APPLY constant
src/platform/endpoint/node/proxy4oEndpoint.ts Integrated ProxyModelsService with conditional model selection logic, falling back to InstantApplyModelName config or GPT4OPROXY constant

@bpasero bpasero assigned 24anisha and unassigned bpasero Dec 9, 2025
@alexdima alexdima changed the title Instant Apply -> Fireworks deployment Instant Apply -> respect proxy's /models Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants