Skip to content

Ensure chat exported log captures actual request info #2531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhichli merged 1 commit into from
Dec 11, 2025
Merged

Ensure chat exported log captures actual request info #2531

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 21 additions & 13 deletions src/extension/log/vscode-node/requestLogTree.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,16 @@ export class RequestLogTree extends Disposable implements IExtensionContribution

let server: RequestServer | undefined;

const getExportableLogEntries = (treeItem: ChatPromptItem): LoggedInfo[] => {
const getExportableLogEntries = (treeItem: ChatPromptItem, lastChatRequestItem?: ChatRequestItem): LoggedInfo[] => {
if (!treeItem || !treeItem.children) {
return [];
}

// lastChatRequestItem logs the actual request info, so use it if present
if (lastChatRequestItem && treeItem.children.length > 0 && treeItem.children[0] instanceof ChatRequestItem) {
treeItem.children[0] = lastChatRequestItem;
}

const logEntries = treeItem.children.map(child => {
if (child instanceof ChatRequestItem || child instanceof ToolCallItem || child instanceof ChatElementItem) {
return child.info;
Expand All @@ -60,8 +65,8 @@ export class RequestLogTree extends Disposable implements IExtensionContribution
};

// Helper method to process log entries for a single prompt
const preparePromptLogsAsJson = async (treeItem: ChatPromptItem): Promise<any> => {
const logEntries = getExportableLogEntries(treeItem);
const preparePromptLogsAsJson = async (treeItem: ChatPromptItem, lastChatRequestItem?: ChatRequestItem): Promise<any> => {
const logEntries = getExportableLogEntries(treeItem, lastChatRequestItem);

if (logEntries.length === 0) {
return;
Expand Down Expand Up @@ -414,10 +419,9 @@ export class RequestLogTree extends Disposable implements IExtensionContribution
return;
}

// Filter to get only ChatPromptItem instances
const chatPromptItems = allTreeItems.filter((item): item is ChatPromptItem => item instanceof ChatPromptItem);
const exportableItems = allTreeItems.filter(item => item instanceof ChatPromptItem || item instanceof ChatRequestItem);

if (chatPromptItems.length === 0) {
if (exportableItems.length === 0) {
vscode.window.showInformationMessage('No chat prompts found to export.');
return;
}
Expand Down Expand Up @@ -452,13 +456,17 @@ export class RequestLogTree extends Disposable implements IExtensionContribution
const allPromptsContent: any[] = [];
let totalLogEntries = 0;

// Process each chat prompt item using the shared function
for (const chatPromptItem of chatPromptItems) {
// Use the shared processing function
const promptObject = await preparePromptLogsAsJson(chatPromptItem);
if (promptObject) {
allPromptsContent.push(promptObject);
totalLogEntries += promptObject.logCount;
let lastChatRequestItem: ChatRequestItem | undefined;
for (const exportableItem of exportableItems) {
if (exportableItem instanceof ChatRequestItem) {
lastChatRequestItem = exportableItem;
} else if (exportableItem instanceof ChatPromptItem) {
const promptObject = await preparePromptLogsAsJson(exportableItem, lastChatRequestItem);
if (promptObject) {
allPromptsContent.push(promptObject);
totalLogEntries += promptObject.logCount;
}
lastChatRequestItem = undefined;
}
}

Expand Down