fix: add CNAME to deploy script and site_url for docs.codecarbon.io#1086
Merged
SaboniAmine merged 1 commit intomasterfrom Feb 27, 2026
Merged
fix: add CNAME to deploy script and site_url for docs.codecarbon.io#1086SaboniAmine merged 1 commit intomasterfrom
SaboniAmine merged 1 commit intomasterfrom
Conversation
- deploy-docs.sh: write CNAME file so every deploy includes custom domain - mkdocs.yml: set site_url to docs.codecarbon.io for correct asset paths Merging to master will trigger the deploy-docs workflow, which will push to gh-pages with CNAME included. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will this trigger the workflow? Yes. The deploy-docs workflow runs on push to
masterwhenscripts/deploy-docs.shormkdocs.ymlchanges. Merging this PR will trigger a deploy that pushes to gh-pages with the CNAME file included.Changes:
scripts/deploy-docs.sh: Write CNAME file (docs.codecarbon.io) on every deploy so future deploys always include the custom domainmkdocs.yml: Setsite_urltohttps://docs.codecarbon.io/for correct asset paths when served from the custom domainRelated: PR #1085 adds CNAME directly to gh-pages for immediate fix. This PR ensures master has the fix so the deploy workflow keeps CNAME on every future deploy.
Made with Cursor