Skip to content

chore: clean up optional dependencies #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexhancock merged 1 commit into from
Jan 14, 2026
Merged

chore: clean up optional dependencies #546

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions crates/rmcp/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ tokio-util = { version = "0.7" }
pin-project-lite = "0.2"
pastey = { version = "0.2.0", optional = true }
# oauth2 support
oauth2 = { version = "5.0", optional = true }
oauth2 = { version = "5.0", optional = true, default-features = false, features = ["reqwest"] }

# for auto generate schema
schemars = { version = "1.0", optional = true, features = ["chrono04"] }
Expand Down Expand Up @@ -108,7 +108,7 @@ client-side-sse = ["dep:sse-stream", "dep:http"]

# Streamable HTTP client
transport-streamable-http-client = ["client-side-sse", "transport-worker"]
transport-streamable-http-client-reqwest = ["transport-streamable-http-client", "reqwest"]
transport-streamable-http-client-reqwest = ["transport-streamable-http-client", "__reqwest"]

transport-async-rw = ["tokio/io-util", "tokio-util/codec"]
transport-io = ["transport-async-rw", "tokio/io-std"]
Expand Down Expand Up @@ -207,4 +207,4 @@ path = "tests/test_task.rs"
[[test]]
name = "test_streamable_http_priming"
required-features = ["server", "client", "transport-streamable-http-server", "reqwest"]
path = "tests/test_streamable_http_priming.rs"
path = "tests/test_streamable_http_priming.rs"
7 changes: 6 additions & 1 deletion crates/rmcp/src/transport/streamable_http_client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,12 @@ impl<C: StreamableHttpClient> Worker for StreamableHttpClientWorker<C> {
};
// Store session info for cleanup when run() exits (not spawned, so cleanup completes before close() returns)
let session_cleanup_info = session_id.as_ref().map(|sid| {
(self.client.clone(), config.uri.clone(), sid.clone(), config.auth_header.clone())
(
self.client.clone(),
config.uri.clone(),
sid.clone(),
config.auth_header.clone(),
)
});

context.send_to_handler(message).await?;
Expand Down
2 changes: 1 addition & 1 deletion crates/rmcp/tests/test_close_connection.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ mod common;
use std::time::Duration;

use common::handlers::{TestClientHandler, TestServer};
use rmcp::{service::QuitReason, ServiceExt};
use rmcp::{ServiceExt, service::QuitReason};

/// Test that close() properly shuts down the connection
#[tokio::test]
Expand Down