Support OR conditions for content extract#197
Conversation
|
@Mark-H Can we get this merged? pretty please |
|
@Mark-H Don't we want to merge this? This has been working for us internally since 2016. |
|
I'm also using this change for a while now, but just ran into an issue. I can't limit the extract to a specific context with the following config: All contexts are extracted in this case. Reverting the changes in this PR solves it. Changing the where clause to |
0a667a6 to
560fd2e
Compare
560fd2e to
4a61dd8
Compare
|
Might be more logical to filter one level up (i.e. here). The way content is extracted is grouped into directories by context, so if we don't want certain contexts... just don't load those contexts. That could be a new property on the I don't know why I left this one so long, sorry. |
What does it do ?
With this change it's possible to define OR conditions in the
.gitifyconfig for content extraction. The config could look like this:Why is it needed ?
Previously the condition for the current extracting context was added like this
$contextCriteria['context_key'] = $contextKey;- this would destroy the array structure that is needed for the OR condition. With OR conditions you need to add conditions into the sub-arrays.Related issue(s)/PR(s)