fix(enhanced): default remoteType to script for UMD remotes#4397
Draft
ScriptedAlchemy wants to merge 31 commits intomainfrom
Draft
fix(enhanced): default remoteType to script for UMD remotes#4397ScriptedAlchemy wants to merge 31 commits intomainfrom
ScriptedAlchemy wants to merge 31 commits intomainfrom
Conversation
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
|
Cursor Agent can help with this pull request. Just |
🦋 Changeset detectedLatest commit: f6655aa The changes in this PR will be included in the next version bump. This PR includes changesets to release 43 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Bundle Size Report1 package(s) changed, 40 unchanged.
Total dist: 6.88 MB (+2.3 kB (+0.0%)) |
ScriptedAlchemy
changed the title
Co-authored-by: Cursor <cursoragent@cursor.com>
…fallback 1. Change RemoteEntryPlugin from a static top-level import to a lazy require inside apply(). This fixes a TDZ (Temporal Dead Zone) error "Cannot access 'RemoteEntryPlugin' before initialization" that occurred in rstest unit tests due to ESM binding initialization order. 2. Restore the original remoteType fallback logic that uses the library type when it is a valid externals type, defaulting to 'script' only for invalid types like 'umd'. This replaces the isValidExternalsType webpack schema import with an inline Set of known valid types. Co-authored-by: Cursor <cursoragent@cursor.com>
…ion-issue-4294-9fd0
…ion-issue-4294-9fd0
…:module-federation/core into cursor/module-federation-issue-4294-9fd0
ScriptedAlchemy
changed the title
@module-federation/devtools
@module-federation/cli
create-module-federation
@module-federation/data-prefetch
@module-federation/dts-plugin
@module-federation/enhanced
@module-federation/error-codes
@module-federation/esbuild
@module-federation/managers
@module-federation/manifest
@module-federation/metro
@module-federation/metro-plugin-rnc-cli
@module-federation/metro-plugin-rnef
@module-federation/modern-js
@module-federation/modern-js-v3
@module-federation/native-federation-tests
@module-federation/native-federation-typescript
@module-federation/nextjs-mf
@module-federation/node
@module-federation/retry-plugin
@module-federation/rsbuild-plugin
@module-federation/rspack
@module-federation/rspress-plugin
@module-federation/runtime
@module-federation/runtime-core
@module-federation/runtime-tools
@module-federation/sdk
@module-federation/storybook-addon
@module-federation/third-party-dts-extractor
@module-federation/treeshake-frontend
@module-federation/treeshake-server
@module-federation/typescript
@module-federation/utilities
@module-federation/webpack-bundler-runtime
@module-federation/bridge-react
@module-federation/bridge-react-webpack-plugin
@module-federation/bridge-shared
@module-federation/bridge-vue3
@module-federation/inject-external-runtime-core-plugin
commit: |
…ion-issue-4294-9fd0
Resolve the dts-plugin TYPE-001 failure by correcting package entry paths for workspace dependencies and updating RawSource usage for webpack typings. Co-authored-by: Cursor <cursoragent@cursor.com>
Restore sdk and error-codes export paths to the filenames emitted by the current build so CI package resolution no longer fails on these branches. Co-authored-by: Cursor <cursoragent@cursor.com>
Use the computed remoteType when wiring ContainerReferencePlugin and constrain its type to the federation option contract to avoid CI TypeScript failures. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
remoteTypetoscriptin enhanced plugin flows where it is omittedModuleFederationPluginremote option behaviorChanged Packages
@module-federation/enhancedChangesets
.changeset/short-crabs-join.md(@module-federation/enhanced: patch)Base
main