-
Notifications
You must be signed in to change notification settings - Fork 246
chore(components): upgrade LeafyGreen components COMPASS-9642 #7406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
||
| useLayoutEffect(() => { | ||
| if (autoFocus) { | ||
| throw new Error('BaseEditor is missing an implementation of autoFocus'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is missing an implementation and tests.
| const editorRef = React.createRef<EditorRef>(); | ||
| render( | ||
| <CodemirrorMultilineEditor text={'{}'} autoFocus ref={editorRef} /> | ||
| ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test needs an assertion that the editor is actually getting focussed.
42a8977 to
105301d
Compare
357fdc0 to
908f33c
Compare
98bbd8e to
5b27667
Compare
This was fixed in LG-5063
2864dc2 to
6e55040
Compare
d6f913f to
7ea2311
Compare
7ea2311 to
848b6fb
Compare
848b6fb to
c01b470
Compare
|
This PR got superseded by a couple of more narrow PRs. |

Description
Merging this PR will:
jsdommissing support forHTMLDialogElement:compass/configs/mocha-config-compass/register/jsdom-extra-mocks-register.js
Lines 38 to 51 in 3c55834
backdropClassName, renamed fromclassName) onModal,MarketingModalandConfirmationModal.Checklist
Motivation and Context
Open Questions
Dependents
Types of changes