Skip to content

Conversation

@relud
Copy link
Collaborator

@relud relud commented Nov 6, 2025

Description

This PR adds shredder config for using fxa delete events to delete subplat cirrus pings,
and adds experiment monitoring config for experimenter_cirrus and subplat_cirrus

Related Tickets & Documents

Reviewer, please follow this checklist

@relud
Copy link
Collaborator Author

relud commented Nov 10, 2025

this is blocked on mozilla/probe-scraper#963 creating the targeted tables

@relud relud changed the title chore(shredder): propagate fxa and subplat deletes to cirrus chore(shredder): propagate subplat deletes to cirrus Dec 2, 2025
@relud
Copy link
Collaborator Author

relud commented Dec 2, 2025

as I understand it, this is not blocked on https://github.com/mozilla-services/cloudops-infra/pull/6696, because the table has already been created

Copy link
Contributor

@mikewilli mikewilli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo fix but otherwise LGTM

Copy link
Contributor

@sean-rose sean-rose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I belatedly thought of a couple more things.

Also, I'm curious whether you've been able to test this ETL code yourself to verify it works end to end. If not, we'll probably want to be careful to deploy this at a time when you're available to quick-fix any issues that may arise.

CROSS JOIN
subplat_namespaces
WHERE
DATE(delete_events.submission_timestamp) = @submission_date
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question (blocking): Is it OK for this table to only have records from whenever it's deployed going forward?

If not, you'll probably want to output a different submission_timestamp condition for the table initialization query using Jinja and the is_init() function, including the appropriate historical range of dates.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

going forward is fine, we can truncate the impacted tables to avoid complicating this, esp knowing this is supposed to be "temporary" until some dev time is available after the EoY code freeze

@relud
Copy link
Collaborator Author

relud commented Dec 2, 2025

Also, I'm curious whether you've been able to test this ETL code yourself to verify it works end to end. If not, we'll probably want to be careful to deploy this at a time when you're available to quick-fix any issues that may arise.

I lack permissions to verify that getting secret values works as intended, I have manually confirmed the uid translation works as intended, as long as it's after 9am PST i'm available to fix

@sean-rose
Copy link
Contributor

The deploy-changes-to-stage CI job failures are for materialized views, which often seem to be a problem when it comes to deployments. I'm not sure whether this is a known issue or some new breakage.

However, one easy way to unblock deployment of subscription_platform_backend_cirrus_derived.delete_events_v1 would be moving the experiment monitoring config changes to a separate PR.

@relud
Copy link
Collaborator Author

relud commented Dec 3, 2025

split out #8548

@mikewilli mikewilli added this pull request to the merge queue Dec 4, 2025
Merged via the queue into mozilla:main with commit 8ce2eca Dec 4, 2025
22 checks passed
@relud relud deleted the patch-1 branch December 5, 2025 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CLONE - Step 8: Add subplat's deletion requests to cirrus shredder config

4 participants