Skip to content

feat: mark exact_mau28 and firefox_desktop_usage queries as deprecated #8568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kik-kik wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: mark exact_mau28 and firefox_desktop_usage queries as deprecated #8568

kik-kik wants to merge 1 commit into from

Conversation

@kik-kik
Copy link
Contributor

@kik-kik kik-kik commented Dec 8, 2025

feat: mark exact_mau28 and firefox_desktop_usage queries as deprecated

Those are no longer needed and are no longer used for our kpi calculations.

@kik-kik kik-kik self-assigned this Dec 8, 2025
@dataops-ci-bot

This comment has been minimized.

Sign in to view
@kik-kik kik-kik force-pushed the feat/DENG-316/deprecate-firefox_desktop_usage_2021-and-exact-mau-datasets branch from 2068997 to 602acbf Compare December 9, 2025 10:46
@dataops-ci-bot
Copy link

dataops-ci-bot commented Dec 9, 2025

Integration report for "feat: mark exact_mau28 and firefox_desktop_usage queries as deprecated"

sql.diff

Click to expand! 
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/telemetry_derived/firefox_desktop_exact_mau28_by_client_count_dimensions_v1/metadata.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/telemetry_derived/firefox_desktop_exact_mau28_by_client_count_dimensions_v1/metadata.yaml
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/telemetry_derived/firefox_desktop_exact_mau28_by_client_count_dimensions_v1/metadata.yaml	2025-12-09 10:49:25.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/telemetry_derived/firefox_desktop_exact_mau28_by_client_count_dimensions_v1/metadata.yaml	2025-12-09 10:49:02.000000000 +0000
@@ -22,13 +22,11 @@
     expiration_days: null
   range_partitioning: null
   clustering: null
-workgroup_access:
-- role: roles/bigquery.dataViewer
-  members:
-  - workgroup:mozilla-confidential
+workgroup_access: []
 references:
   query.sql:
   - moz-fx-data-shared-prod.static.country_codes_v1
   - moz-fx-data-shared-prod.telemetry.clients_last_seen
+deprecated: true
 require_column_descriptions: false
 level: null
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/telemetry_derived/firefox_desktop_exact_mau28_by_dimensions_v1/metadata.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/telemetry_derived/firefox_desktop_exact_mau28_by_dimensions_v1/metadata.yaml
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/telemetry_derived/firefox_desktop_exact_mau28_by_dimensions_v1/metadata.yaml	2025-12-09 10:49:25.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/telemetry_derived/firefox_desktop_exact_mau28_by_dimensions_v1/metadata.yaml	2025-12-09 10:49:02.000000000 +0000
@@ -22,13 +22,11 @@
     expiration_days: null
   range_partitioning: null
   clustering: null
-workgroup_access:
-- role: roles/bigquery.dataViewer
-  members:
-  - workgroup:mozilla-confidential
+workgroup_access: []
 references:
   query.sql:
   - moz-fx-data-shared-prod.static.country_codes_v1
   - moz-fx-data-shared-prod.telemetry.clients_last_seen_v1
+deprecated: true
 require_column_descriptions: false
 level: null
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/telemetry_derived/firefox_desktop_exact_mau28_by_dimensions_v2/metadata.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/telemetry_derived/firefox_desktop_exact_mau28_by_dimensions_v2/metadata.yaml
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/telemetry_derived/firefox_desktop_exact_mau28_by_dimensions_v2/metadata.yaml	2025-12-09 10:49:25.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/telemetry_derived/firefox_desktop_exact_mau28_by_dimensions_v2/metadata.yaml	2025-12-09 10:49:03.000000000 +0000
@@ -24,12 +24,10 @@
     expiration_days: null
   range_partitioning: null
   clustering: null
-workgroup_access:
-- role: roles/bigquery.dataViewer
-  members:
-  - workgroup:mozilla-confidential
+workgroup_access: []
 references:
   query.sql:
   - moz-fx-data-shared-prod.telemetry.clients_last_seen
+deprecated: true
 require_column_descriptions: false
 level: null
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/telemetry_derived/firefox_desktop_usage_v1/metadata.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/telemetry_derived/firefox_desktop_usage_v1/metadata.yaml
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/telemetry_derived/firefox_desktop_usage_v1/metadata.yaml	2025-12-09 10:49:25.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/telemetry_derived/firefox_desktop_usage_v1/metadata.yaml	2025-12-09 10:49:03.000000000 +0000
@@ -36,13 +36,11 @@
     - attributed
     - country
     - country_name
-workgroup_access:
-- role: roles/bigquery.dataViewer
-  members:
-  - workgroup:mozilla-confidential
+workgroup_access: []
 references:
   query.sql:
   - moz-fx-data-shared-prod.static.country_codes_v1
   - moz-fx-data-shared-prod.telemetry_derived.firefox_desktop_exact_mau28_by_dimensions_v2
+deprecated: true
 require_column_descriptions: false
 level: null
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/telemetry_derived/firefox_nondesktop_day_2_7_activation_v1/metadata.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/telemetry_derived/firefox_nondesktop_day_2_7_activation_v1/metadata.yaml
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/telemetry_derived/firefox_nondesktop_day_2_7_activation_v1/metadata.yaml	2025-12-09 10:49:25.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/telemetry_derived/firefox_nondesktop_day_2_7_activation_v1/metadata.yaml	2025-12-09 10:49:02.000000000 +0000
@@ -23,12 +23,10 @@
     expiration_days: null
   range_partitioning: null
   clustering: null
-workgroup_access:
-- role: roles/bigquery.dataViewer
-  members:
-  - workgroup:mozilla-confidential
+workgroup_access: []
 references:
   query.sql:
   - moz-fx-data-shared-prod.telemetry.nondesktop_clients_last_seen
+deprecated: true
 require_column_descriptions: false
 level: null
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/telemetry_derived/firefox_nondesktop_exact_mau28_by_client_count_dimensions_v1/metadata.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/telemetry_derived/firefox_nondesktop_exact_mau28_by_client_count_dimensions_v1/metadata.yaml
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/telemetry_derived/firefox_nondesktop_exact_mau28_by_client_count_dimensions_v1/metadata.yaml	2025-12-09 10:49:25.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/telemetry_derived/firefox_nondesktop_exact_mau28_by_client_count_dimensions_v1/metadata.yaml	2025-12-09 10:49:01.000000000 +0000
@@ -22,13 +22,11 @@
     expiration_days: null
   range_partitioning: null
   clustering: null
-workgroup_access:
-- role: roles/bigquery.dataViewer
-  members:
-  - workgroup:mozilla-confidential
+workgroup_access: []
 references:
   query.sql:
   - moz-fx-data-shared-prod.static.country_codes_v1
   - moz-fx-data-shared-prod.telemetry.core_clients_last_seen_v1
+deprecated: true
 require_column_descriptions: false
 level: null
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/telemetry_derived/firefox_nondesktop_exact_mau28_v1/metadata.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/telemetry_derived/firefox_nondesktop_exact_mau28_v1/metadata.yaml
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/telemetry_derived/firefox_nondesktop_exact_mau28_v1/metadata.yaml	2025-12-09 10:49:25.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/telemetry_derived/firefox_nondesktop_exact_mau28_v1/metadata.yaml	2025-12-09 10:49:02.000000000 +0000
@@ -21,12 +21,10 @@
     expiration_days: null
   range_partitioning: null
   clustering: null
-workgroup_access:
-- role: roles/bigquery.dataViewer
-  members:
-  - workgroup:mozilla-confidential
+workgroup_access: []
 references:
   query.sql:
   - moz-fx-data-shared-prod.telemetry.nondesktop_clients_last_seen
+deprecated: true
 require_column_descriptions: false
 level: null

Link to full diff

BenWu
BenWu reviewed Dec 9, 2025
View reviewed changes
...od/telemetry_derived/firefox_desktop_exact_mau28_by_client_count_dimensions_v1/metadata.yaml
range_partitioning: null
clustering: null
require_column_descriptions: false
deprecated: true
Copy link
Contributor

@BenWu BenWu Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While it doesn't actually do anything, the deletion_date field that the bqetl cli adds would be useful to set a soft target date for deletion so we can be more confident in deleting it in the future if it lingers around

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BenWu BenWu BenWu left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@kik-kik kik-kik

Labels

deprecation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kik-kik @dataops-ci-bot @BenWu