Skip to content

feat(events_stream): Add document_event_number column to events_stream_v1 tables and event_id column to events_stream views (DENG-9800) #8596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sean-rose merged 3 commits into from
Dec 12, 2025
Merged

feat(events_stream): Add document_event_number column to events_stream_v1 tables and event_id column to events_stream views (DENG-9800) #8596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
93607b5
feat(events_stream): Add `document_event_number` column to `events_st…
sean-rose Dec 11, 2025
d2d501a
feat(events_stream): Add `event_id` column to `events_stream` views.
sean-rose Dec 11, 2025
309fdf2
Merge remote-tracking branch 'origin/main' into DENG-9800-events-stre…
sean-rose Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sql_generators/glean_usage/templates/cross_channel_events_stream.query.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ WITH events_stream_union AS (
{% endfor %}
)
SELECT
CONCAT(document_id, '-', document_event_number) AS event_id,
*,
{% if extras_by_type %}
{{ event_extras_by_type_struct(extras_by_type) }} AS extras
Expand Down
1 change: 1 addition & 0 deletions sql_generators/glean_usage/templates/events_stream.view.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ CREATE OR REPLACE VIEW
`{{ project_id }}.{{ events_stream_view }}`
AS
SELECT
CONCAT(document_id, '-', document_event_number) AS event_id,
*,
{% if extras_by_type %}
{{ event_extras_by_type_struct(extras_by_type) }} AS extras
Expand Down
2 changes: 2 additions & 0 deletions sql_generators/glean_usage/templates/events_stream_v1.query.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,10 +135,12 @@ SELECT
event.name AS event_name,
ARRAY_TO_STRING([event.category, event.name], '.') AS event, -- handles NULL values better
from_map_event_extra(event.extra) AS event_extra,
(event_offset + 1) AS document_event_number,
FROM
base
CROSS JOIN
UNNEST(events) AS event
WITH OFFSET AS event_offset
{% if app_name == "firefox_desktop" %}
WHERE
-- See https://mozilla-hub.atlassian.net/browse/DENG-7513
Expand Down