Skip to content

Command line cleanup #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jgraham wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Command line cleanup #456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions jobs/webcompat-kb/webcompat_kb/interop.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import argparse
import logging
import re
import os
from dataclasses import dataclass
from datetime import datetime
from typing import Iterable, Mapping, MutableMapping, Optional, Sequence
Expand Down Expand Up @@ -306,17 +305,12 @@ def add_arguments(cls, parser: argparse.ArgumentParser) -> None:
action="store_true",
help="Recreate Interop data",
)
group.add_argument(
"--interop-github-token",
default=os.environ.get("GH_TOKEN"),
help="GitHub token",
)

def default_dataset(self, context: Context) -> str:
return "interop"

def main(self, context: Context) -> None:
gh_client = GitHub(context.args.interop_github_token)
gh_client = GitHub(context.args.github_token)
update_interop_data(
context.project,
context.bq_client,
Expand Down
8 changes: 3 additions & 5 deletions jobs/webcompat-kb/webcompat_kb/web_features.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,22 +334,20 @@ def add_arguments(cls, parser: argparse.ArgumentParser) -> None:
group = parser.add_argument_group(
title="Web Features", description="Web Features arguments"
)
# Legacy: BigQuery Web Features dataset id
group.add_argument(
"--bq-web-features-dataset",
type=dataset_arg,
help="BigQuery Web Features dataset id",
help=argparse.SUPPRESS,
)
group.add_argument(
"--recreate-web-features",
action="store_true",
help="Delete and recreate web features tables from scratch",
)

def required_args(self) -> set[str | tuple[str, str]]:
return {"bq_web_features_dataset"}

def default_dataset(self, context: Context) -> str:
return context.args.bq_web_features_dataset
return "web_features"

def main(self, context: Context) -> None:
update_web_features(context.bq_client, context.args.recreate_web_features)