Fix getElementAttachedOffsets returns radians instead of degrees#4726
Open
Xenius97 wants to merge 6 commits intomultitheftauto:masterfrom
Open
Fix getElementAttachedOffsets returns radians instead of degrees#4726Xenius97 wants to merge 6 commits intomultitheftauto:masterfrom
getElementAttachedOffsets returns radians instead of degrees#4726Xenius97 wants to merge 6 commits intomultitheftauto:masterfrom
Conversation
…ntAttachedOffsets
Member
|
What about client side? |
Contributor
Author
client has no issues |
Member
|
Hmm, personally I think it would be better to determine the cause of this change and where it occurred, since this is a new issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes
getElementAttachedOffsetsreturns radians instead of degreesMotivation/Info
Attempted to fix #4724 but when i restored original code (before #4680) first issue is the same, something else did break it cause in 1.6 works fine.
For some reason streaming doesn't uses the right angle when creating object on client side after reconnecting, getElementRotation and getElementPosition are returning correct position/angle on server side. If you're standing right to the object you will see in right angle, but after you reconnect it will be bugged again.
I don't know someone else did make changes in these, but i've reverted on local branch my changes and seems broken too.

For some reason

getElementAttachedOffsetsreturns now radians:gta_sa_8HnTvu7zTi.mp4
After this fix

getElementAttachedOffsetsreturns the correct values but bug mentioned in #4724 still existing.Test plan
Checklist