Upgrades and refactoring #205
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r (setting the stage for adding a % tracker of non-standar-ingest transcoding)
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jsanford8
commented
Jul 7, 2025
Collaborator
Author
jsanford8
left a comment
jsanford8
left a comment
There was a problem hiding this comment.
in general, looks pretty reasonable. A couple of minor things to change
| type Props = null; | ||
|
|
||
| const Index: React.FC<Props> = () => { | ||
| console.log('INDEX PAGE LOADED - TEST LOG'); |
Collaborator
Author
There was a problem hiding this comment.
please remove this
| <Button className={isUploading ? 'hidden' : '' } slot="file-select">Upload video</Button> | ||
| </MuxUploader> | ||
| {(() => { | ||
| console.log('INDEX: Rendering MuxUploader, isUploading:', isUploading); |
|
|
||
| expect(res._getStatusCode()).toBe(200); | ||
| }); | ||
| }); No newline at end of file |
Collaborator
Author
There was a problem hiding this comment.
there's a bunch of files with no newlines at the end. Maybe you can configure claude to fix that up?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.