Open
Conversation
petrvanekrobe
force-pushed
the
device_naming_clarification
branch
2 times, most recently
from
1db4b7c to
fa0e6e6
Compare
petrvanekrobe
force-pushed
the
device_naming_clarification
branch
from
fa0e6e6 to
f4f989b
Compare
ILane-VW
approved these changes
Dec 18, 2025
petrvanekrobe
force-pushed
the
device_naming_clarification
branch
from
dede612 to
cc995c6
Compare
Contributor
Author
|
@ILane-VW we have done some changes in our meeting today, please look at the final result now :) |
Yes I think the changes look good. We will need to modify the gdtf share to search for the long name and display the short name. And we will apply the naming rules for the created zip archive. Have you created a separate issue to track this requested work already? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs more work. #291