Skip to content

Conversation

@sanjay20m
Copy link

This PR improves the Terraform configuration by replacing the use of the hardcoded var.account_id variable with the dynamic aws_caller_identity data source within the db_provision IAM policy. This update:

Aligns with Terraform best practices

Reduces required configuration variables

Improves portability and security

##Files Changed
terraform/modules/data-persistence/main.tf

CHANGELOG.md

##Related Changelog Entry
Under ## [Unreleased]:

markdown
Copy
Edit

  • CUMULUS-XXXX
    • Replaced use of var.account_id with the aws_caller_identity data source in the db_provision IAM policy to avoid requiring a hardcoded account ID in configuration. This improves portability and aligns with Terraform best practices.

@sanjay20m
Copy link
Author

sanjay20m commented Jul 18, 2025

@Jkovarik any changes required now !!

@sanjay20m
Copy link
Author

Hi @Jkovarik,
Just following up to see if this is ready for review. All updates have been made per guidelines, including the changelog entry and replacing var.account_id with aws_caller_identity for better portability and security.

Please let me know if anything else is needed. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants