Skip to content

Conversation

alexskr and others added 14 commits February 3, 2025 17:30
Add `system_controlled` DSL to LinkedData::Hypermedia::Resource

- Adds `:system_controlled` to the DSL SETTINGS list
- Allows declaring system-assigned (internally-managed) attributes in model classes
- Intended for use in the API layer to reject client input for restricted fields like `uploadFilePath`
- Mirrors the behavior of other DSLs like `serialize_never` (last call wins)
- Add selected attributes to system_controlled list for User, OntologySubmission, Note and Project model as a proof of concept. More models may follow after further analysis.

See ncbo/bioportal-project#348
Feature: submission version validation and fixes to the metadata auto-extraction
@alexskr alexskr marked this pull request as ready for review August 8, 2025 19:47
@codecov
Copy link

codecov bot commented Aug 8, 2025

Codecov Report

❌ Patch coverage is 70.00000% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.21%. Comparing base (d55bddd) to head (2bbdfc9).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...ology_submissions/submission_metadata_extractor.rb 64.28% 15 Missing ⚠️
...ion_process/operations/submission_rdf_generator.rb 33.33% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #255      +/-   ##
==========================================
- Coverage   80.23%   80.21%   -0.02%     
==========================================
  Files          84       84              
  Lines        5808     5843      +35     
==========================================
+ Hits         4660     4687      +27     
- Misses       1148     1156       +8     
Flag Coverage Δ
unittests 80.21% <70.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alexskr alexskr merged commit 0b20d55 into master Aug 8, 2025
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants