You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
hi @afurm , thanks for the PR! could you point which .md is showing problems that this PR fixes? I'm trying to figure out if this is a real issue, or the +1 is actually not affecting the results
hi @afurm , thanks for the PR! could you point which .md is showing problems that this PR fixes? I'm trying to figure out if this is a real issue, or the +1 is actually not affecting the results
This is a real issue, but specifically in the markdown generated by yarn process-markdown (website/scripts/copy-md-to-static.js), not in the runtime <Github> component used on rendered docs pages.
Concrete examples where end gets one extra line before this fix:
docs/web3-apps/quickstart.md (line 118) <Github ... start="11" end="11" />
Source file is hello-near/index.tsx, where line 11 is: const { signedAccountId, viewFunction, callFunction } = useNearWallet();
With the old +1, line 12 is also included.
docs/web3-apps/tutorials/wallet-login.md (line 118) <Github ... start="3" end="3" />
This should include only line 3, but old logic includes the next line too.
So the fix aligns copy-md-to-static.js behavior with the existing frontend GitHub component behavior (slice(start-1, end)).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<File ... start="x" end="y" />snippet extraction had an off-by-one bug that included one extra line afterend.This PR:
enddoes not include the next linestart="2" end="3"to ensure only lines 2–3 are returnedrequire.mainguard/export so the helper can be tested directly without changing normal script executionBefore / After
start=2, end=3returned lines2, 3, 4start=2, end=3returns lines2, 3Testing