fix(runtime): ensure that runtime is resolved correctly#303
Open
asmodeus812 wants to merge 7 commits intoneoclide:masterfrom
Open
fix(runtime): ensure that runtime is resolved correctly#303asmodeus812 wants to merge 7 commits intoneoclide:masterfrom
asmodeus812 wants to merge 7 commits intoneoclide:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The runtime was not really resolved in a well structured way, the JRE was always getting downloaded even if the user choose to use preference options. On top of that the way the runtime was decided for the initial project was also very restricted, this change ensures that a more exhaustive approach is used for both the tooling that will start the language server and the initial runtime for the project.