feat(recent-search): include recently uploaded files in addition to modified files

[cristianscheid]

• Resolves: #

Summary

Updates the recent files search query to include files that were recently uploaded in addition to files that were recently modified. The search now uses an OR condition to match files where either getlastmodified OR getuploadtime is within the specified time threshold.

This change depends on this backend PR which adds support for the getuploadtime property in file search queries:

• feat: add upload_time support to file search and recent files nextcloud/server#58327

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)
• Labels added where applicable (ex: bug/enhancement, 3. to review, feature component)
• Milestone added for target branch/version (ex: 32.x for stable32)

[codecov]

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.77%. Comparing base (bd65425) to head (2647836).
⚠️ Report is 12 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/dav/davProperties.ts	50.00%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1498      +/-   ##
==========================================
- Coverage   85.99%   85.77%   -0.22%     
==========================================
  Files          30       30              
  Lines         664      668       +4     
  Branches      194      198       +4     
==========================================
+ Hits          571      573       +2     
  Misses         81       81              
- Partials       12       14       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[susnux]

Lets wait for nextcloud/server#58327 to be merged before merging this.

[cristianscheid]

Lets wait for nextcloud/server#58327 to be merged before merging this.

@susnux The PR was merged, should we go ahead and merge this one as well?

[susnux]

What came to my mind:

Does this work without the merged PR?
What will happen if you use this feature with 33.0.0 where it was not yet merged?
If it will cause errors we need to put this behind a capability.

[cristianscheid]

Does this work without the merged PR? What will happen if you use this feature with 33.0.0 where it was not yet merged?

@susnux Good catch! If we use this feature with server 33.0.0 it will cause errors, since we did not backport the server to that version. Can we still backport the server PR to 33?

If it will cause errors we need to put this behind a capability.

Do you have an approach in mind for this?

[susnux]

Either put a new capability into server or use the version

const major = Number.parseInt((window.OC?.config?.version ?? '0').split('.')[0])
const path = Number.parseInt((window.OC?.config?.version ?? '0').split('.')[2])

if (major > 33 || (major === 33 && patch > 0)) {
    // now use the new stuff
}

[cristianscheid]

Either put a new capability into server or use the version

const major = Number.parseInt((window.OC?.config?.version ?? '0').split('.')[0])
const path = Number.parseInt((window.OC?.config?.version ?? '0').split('.')[2])

if (major > 33 || (major === 33 && patch > 0)) {
    // now use the new stuff
}

Thanks for the suggestion @susnux! I’ve just finished the implementation.