Skip to content

Conversation

@salmart-dev
Copy link
Contributor

@salmart-dev salmart-dev commented Dec 30, 2025

  • Target version: 33

Summary

Implements support for IPartialShareProvider (nextcloud/server#57285)

NOTE: IPartialMountProvider works on the assumption that the calls happens with a relatively up-to-date oc_mounts table (updated every 5 minutes and when accessing the user's root). For this reason it should be possible to skip checks (like membership or boards) as they are performed regularly.

TODO

  • Check: is it necessary to double-check that the user still has access to the board?
  • Write tests

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

@salmart-dev salmart-dev self-assigned this Dec 30, 2025
@salmart-dev salmart-dev force-pushed the feature/54562/implement-ipartialshareprovider branch 3 times, most recently from 5036aee to 51b3ff9 Compare January 2, 2026 11:38
@artonge artonge force-pushed the feature/54562/implement-ipartialshareprovider branch from a8757db to 51b3ff9 Compare January 7, 2026 17:21
@artonge artonge added enhancement 3. to review php Pull requests that update Php code and removed 2. developing labels Jan 9, 2026
@artonge artonge force-pushed the feature/54562/implement-ipartialshareprovider branch from 51b3ff9 to 104d414 Compare January 9, 2026 10:16
@artonge artonge marked this pull request as ready for review January 9, 2026 15:42
@artonge artonge force-pushed the feature/54562/implement-ipartialshareprovider branch 2 times, most recently from c07d854 to 98ae844 Compare January 13, 2026 11:35
@artonge artonge force-pushed the feature/54562/implement-ipartialshareprovider branch from 98ae844 to 63278ab Compare January 14, 2026 14:01
Signed-off-by: Salvatore Martire <[email protected]>
Signed-off-by: Louis Chmn <[email protected]>
@artonge artonge force-pushed the feature/54562/implement-ipartialshareprovider branch from 63278ab to 04904ff Compare January 14, 2026 15:12
@artonge artonge merged commit e47a3ac into main Jan 14, 2026
47 of 53 checks passed
@artonge artonge deleted the feature/54562/implement-ipartialshareprovider branch January 14, 2026 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants