-
Notifications
You must be signed in to change notification settings - Fork 301
feat(nextcloud): add support of imaginary an externalPreviewProvider #622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6ace176 to
44beda3
Compare
04d871c to
5b0fc90
Compare
|
ping @jessebot / @provokateurin do you like to review? |
|
Sorry, I don't have the time for that atm. I hope I can do it at some point, but only at the beginning of next month the earliest. |
5b0fc90 to
13cba3b
Compare
|
oh this is neat! May I ask what the difference between this and the preview generator app are? (I'm not against it btw, just want to learn more) I will review this more thoroughly as soon as I have a moment 🙏 |
4389148 to
0c32ab9
Compare
jessebot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for this! Perhaps we can add another PR for adding a CI test of some sort in the future?
|
Thank you for working on this 🚀 |
490e772 to
fd741c3
Compare
|
rebased on main and add docu in e393d90 like @SIMULATAN suggested |
fd741c3 to
e393d90
Compare
3f7a295 to
687f8b9
Compare
|
rebased, squashed und test added |
687f8b9 to
13c32f8
Compare
13c32f8 to
592b11f
Compare
fb41953 to
3613d83
Compare
3613d83 to
86b2516
Compare
|
I found the bug, in the container (why setup of test does not run) .... So here are the test online. |
3dbdd53 to
404383f
Compare
404383f to
cf92712
Compare
|
rebased / updated - still ready to merge |
4c2c5e8 to
63796c0
Compare
|
rebased |
jessebot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, you can merge this now! (sorry for the extreme delay 🙇 )
Signed-off-by: WrenIX <[email protected]>
Signed-off-by: WrenIX <[email protected]>
Signed-off-by: WrenIX <[email protected]>
63796c0 to
9b7a468
Compare
Description of the change
Benefits
Possible drawbacks
Works for me.
TODO:
Checklist
Chart.yamlaccording to semver.