Skip to content

Comments

edit captions#5686

Merged
mahibi merged 7 commits intomasterfrom
fix/5685/EditCaptions
Jan 22, 2026
Merged

edit captions#5686
mahibi merged 7 commits intomasterfrom
fix/5685/EditCaptions

Conversation

@sowjanyakch
Copy link
Contributor

@sowjanyakch sowjanyakch commented Jan 6, 2026 •
edited
Loading

fix #5685

  • edit captions
  • show time, edited tag and checkmark for attachment messages.
  • editing captions with mentions also work

🖼️ Screenshots

edited message

🚧 TODO

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@sowjanyakch sowjanyakch self-assigned this Jan 6, 2026
@sowjanyakch sowjanyakch added the 3. to review Waiting for reviews label Jan 6, 2026
@sowjanyakch sowjanyakch force-pushed the fix/5685/EditCaptions branch from 9825e02 to ed8e1b1 Compare January 6, 2026 18:08
@rapterjet2004
Copy link
Contributor

rapterjet2004 commented Jan 8, 2026

Please rebase to resolve the merge conflicts

@sowjanyakch sowjanyakch added 1. to develop Accepted and waiting to be taken care of (should be only set by nextcloud employees) and removed 3. to review Waiting for reviews labels Jan 14, 2026
@sowjanyakch sowjanyakch force-pushed the fix/5685/EditCaptions branch from ed8e1b1 to 7a22b55 Compare January 20, 2026 16:40
@sowjanyakch sowjanyakch added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of (should be only set by nextcloud employees) labels Jan 20, 2026
@sowjanyakch @mahibi
edit captions
fd65471 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @mahibi
modify incoming and outcoming preview holders
e539e76 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @mahibi
add edit timestamps
9b08087 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @mahibi
remove extra spacing + format
1ef3a67 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @mahibi
fix merge conflicts
8fa2a06 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @mahibi
merge conflicts + fix layout
25491f2 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@mahibi mahibi force-pushed the fix/5685/EditCaptions branch from 7a22b55 to 25491f2 Compare January 22, 2026 09:47
@mahibi mahibi added this to the 23.0.0 milestone Jan 22, 2026
@mahibi
use NonNull instead org.jetbrains.annotations.NotNull
b7573c4 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@github-actions
Copy link
Contributor

github-actions bot commented Jan 22, 2026

Codacy

Lint

TypemasterPR
Warnings9999
Errors00

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1010
Dodgy code5454
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total8181

@github-actions
Copy link
Contributor

github-actions bot commented Jan 22, 2026

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5686.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@mahibi mahibi merged commit 6fed9df into master Jan 22, 2026
16 of 20 checks passed
@mahibi mahibi deleted the fix/5685/EditCaptions branch January 22, 2026 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mahibi mahibi mahibi approved these changes

@rapterjet2004 rapterjet2004 Awaiting requested review from rapterjet2004

Assignees

@sowjanyakch sowjanyakch

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

23.0.0

Development

Successfully merging this pull request may close these issues.

Captions must also be editable

3 participants

@sowjanyakch @rapterjet2004 @mahibi