Move task hashing logic to separate class #6572
Merged
+417
−299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nextflow-docs-staging canceled.
|
jorgee
reviewed
Nov 17, 2025
modules/nextflow/src/test/groovy/nextflow/processor/TaskProcessorTest.groovy
Show resolved
Hide resolved
modules/nextflow/src/test/groovy/nextflow/processor/TaskProcessorTest.groovy
Show resolved
Hide resolved
pditommaso
previously requested changes
Nov 20, 2025
Member
Author
|
The motivation is in the PR description |
Signed-off-by: Ben Sherman <[email protected]>
Signed-off-by: Ben Sherman <[email protected]>
bentsherman
force-pushed
the
task-hasher
branch
from
ee02d3a to
0ab7470
Compare
jorgee
reviewed
Jan 8, 2026
jorgee
approved these changes
Jan 8, 2026
Contributor
jorgee
left a comment
jorgee
left a comment
There was a problem hiding this comment.
Overall changes look fine with me. Just a minor comment about some method moved to TaskHash to consider to move to TaskRun as it looks like they are just using TaskRun data and they are also called from the LinObserver.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the task hashing logic from
TaskProcessorto a separate classTaskHasher