Skip to content

Strict linting#9893

Merged
muffato merged 6 commits intomasterfrom
strict_linting
Feb 5, 2026
Merged

Strict linting#9893
muffato merged 6 commits intomasterfrom
strict_linting

Conversation

@muffato
Copy link
Member

@muffato muffato commented Feb 5, 2026

A few issues flagged by the linter

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@muffato muffato self-assigned this Feb 5, 2026
Copilot AI review requested due to automatic review settings February 5, 2026 08:42
@github-actions github-actions bot added the size/s label Feb 5, 2026
@muffato muffato requested review from prototaxites and removed request for Copilot February 5, 2026 08:43
@prototaxites
Copy link
Contributor

Looks good to me, but if you were able to fix up hapmaker too I would be very appreciative! https://github.com/nf-core/modules/blob/b4b632dbde91a6a7d50522db89b0408fd8002023/modules/nf-core/merquryfk/hapmaker/main.nf

Copilot AI review requested due to automatic review settings February 5, 2026 09:34
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses several linting issues flagged by the strict linter across multiple nf-core modules. The changes primarily focus on improving code quality and consistency by fixing lambda parameter naming, correcting metadata patterns, adjusting syntax, and fixing environment variable quoting.

Changes:

  • Fixed incorrect pattern in MultiQC metadata (bug fix: pattern was "_data" but should be "_plots")
  • Updated lambda closures to use explicit parameter names instead of implicit "it" parameter across merquryfk modules
  • Corrected errorStrategy directive syntax in blobtk/plot from assignment syntax to direct syntax
  • Fixed environment variable quoting in genescopefk from double quotes to single quotes

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
modules/nf-core/multiqc/meta.yml Corrected pattern from "_data" to "_plots" for the plots output
modules/nf-core/merquryfk/ploidyplot/main.nf Changed lambda parameter from implicit it to explicit path
modules/nf-core/merquryfk/merquryfk/main.nf Changed lambda parameters from implicit it to explicit path in three locations
modules/nf-core/merquryfk/katgc/main.nf Changed lambda parameter from implicit it to explicit path
modules/nf-core/merquryfk/katcomp/main.nf Changed lambda parameters from implicit it to explicit path in two locations
modules/nf-core/merquryfk/hapmaker/main.nf Changed lambda parameters from implicit it to explicit path and added echo statement in stub
modules/nf-core/genescopefk/main.nf Changed env variable from double quotes to single quotes
modules/nf-core/blobtk/plot/main.nf Fixed errorStrategy syntax from assignment form to direct form

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@muffato muffato added this pull request to the merge queue Feb 5, 2026
Merged via the queue into master with commit 575e1a4 Feb 5, 2026
75 checks passed
@muffato muffato deleted the strict_linting branch February 5, 2026 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants