Merged
Conversation
prototaxites
approved these changes
Feb 5, 2026
Contributor
|
Looks good to me, but if you were able to fix up hapmaker too I would be very appreciative! https://github.com/nf-core/modules/blob/b4b632dbde91a6a7d50522db89b0408fd8002023/modules/nf-core/merquryfk/hapmaker/main.nf |
b4b632d to
3602a5e
Compare
prototaxites
approved these changes
Feb 5, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses several linting issues flagged by the strict linter across multiple nf-core modules. The changes primarily focus on improving code quality and consistency by fixing lambda parameter naming, correcting metadata patterns, adjusting syntax, and fixing environment variable quoting.
Changes:
- Fixed incorrect pattern in MultiQC metadata (bug fix: pattern was "_data" but should be "_plots")
- Updated lambda closures to use explicit parameter names instead of implicit "it" parameter across merquryfk modules
- Corrected errorStrategy directive syntax in blobtk/plot from assignment syntax to direct syntax
- Fixed environment variable quoting in genescopefk from double quotes to single quotes
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| modules/nf-core/multiqc/meta.yml | Corrected pattern from "_data" to "_plots" for the plots output |
| modules/nf-core/merquryfk/ploidyplot/main.nf | Changed lambda parameter from implicit it to explicit path |
| modules/nf-core/merquryfk/merquryfk/main.nf | Changed lambda parameters from implicit it to explicit path in three locations |
| modules/nf-core/merquryfk/katgc/main.nf | Changed lambda parameter from implicit it to explicit path |
| modules/nf-core/merquryfk/katcomp/main.nf | Changed lambda parameters from implicit it to explicit path in two locations |
| modules/nf-core/merquryfk/hapmaker/main.nf | Changed lambda parameters from implicit it to explicit path and added echo statement in stub |
| modules/nf-core/genescopefk/main.nf | Changed env variable from double quotes to single quotes |
| modules/nf-core/blobtk/plot/main.nf | Fixed errorStrategy syntax from assignment form to direct form |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few issues flagged by the linter
PR checklist
Closes #XXX
topic: versions- See version_topicslabelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda