Add iou_complement as a configurable alternative distance function to center_distance (for detection and tracking evaluation)#1075
Open
sbarkby wants to merge 8 commits intonutonomy:masterfrom
Open
Conversation
Collaborator
whyekit-motional
left a comment
There was a problem hiding this comment.
Thanks for this feature @sbarkby!
I've done an initial pass on PR (and will look deeper into your code in subsequent passes)
Author
|
Hi @whyekit-motional , thanks for the review, have made the changes you suggested, let me know if you need anything else. Cheers. :) |
Author
|
Hi @whyekit-motional, just checking in, any updates? |
Author
|
Hi @whyekit-motional, just checking in, any updates? Does this need to be transferred to a different reviewer? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the Intersection Over Union complement (1.0 - IOU) as an alternative distance function for determining matches and the calculation of metrics, such as MOTP. The use of this distance function has been made configurable in the detection_cvpr_2019.json and tracking_nips_2019.json config files for detection and tracking evaluation respectively. Fortunately the codebase was already setup to cater for alternative distance functions, so the coding change proposed here is minimal.
Also note that this PR poses no change to the default operation of the evaluator, it will continue to use "center_distance" as it's distance function by default.