fix(nuxt-bridge): add support for nuxt bridge#422
Open
Jamiewarb wants to merge 1 commit intonuxt-modules:v4from
Open
fix(nuxt-bridge): add support for nuxt bridge#422Jamiewarb wants to merge 1 commit intonuxt-modules:v4from
Jamiewarb wants to merge 1 commit intonuxt-modules:v4from
Conversation
Nuxt Bridge exposes the Nuxt 2 context via nuxtApp.nuxt2Context. However, when doing `app.apolloProvider`, the apolloProvider is not added to this context. In order to get the apolloProvider onto this nuxt2Context, we must use inject(). However, it requires a different name than "apolloProvider" when injecting, or we get errors.
307e127 to
e10cdcf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Providing an Apollo Client
Nuxt Bridge exposes the Nuxt 2 context via nuxtApp.nuxt2Context.
However, when assining the apolloProvider to
app.apolloProvider, the apolloProvider is not added to this context. (https://github.com/nuxt-community/apollo-module/blob/master/lib/templates/plugin.js#L115)In order to get the apolloProvider onto this nuxt2Context, we must use inject().
However, it requires a different name than "apolloProvider" when injecting, or we get errors.
With these changes, it's now possible to provide the apollo client as before:
Once the replacement for
onGlobalSetup()is added, we can move this code back to a plugin: nuxt/framework#2408Note: This is a short term solution for Nuxt Bridge, and will need revisiting Nuxt 3.