Skip to content

Conversation

@WizardCM
Copy link
Member

@WizardCM WizardCM commented Apr 1, 2025

Description

Add a couple version checks for logging added in recent hotfixes to ensure continued compilation on the previously supported version of CEF.

Fixes #480

Motivation and Context

Generally, we aim to support the currently shipping CEF version and the previous (in this case 5060) to ensure easy verification of new issues with a current codebase (that is, easy downgrading for comparison), or to be able to easily revert in case of major bugs.

CefGetExitCode() did not exist until 124, and additional parameters were added to OnRenderProcessTerminated.

How Has This Been Tested?

Toggle between CEF versions on Windows. Both compiled.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@WizardCM WizardCM added the Bug Fix Non-breaking change which fixes an issue label Apr 1, 2025
Copy link
Member

@RytoEX RytoEX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would almost rather we just ifdef the entire function signature instead of parts of it, but this is probably fine. I'll think about it.

Copy link
Member

@RytoEX RytoEX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second examination, we already do this elsewhere, so it's probably fine.

@RytoEX RytoEX merged commit a0a0edc into obsproject:master Apr 1, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Fix Non-breaking change which fixes an issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OBS fails to build with CEF5060 due to #475 + #478 , and #477

2 participants