Fix support for building with CEF 5060 #481
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a couple version checks for logging added in recent hotfixes to ensure continued compilation on the previously supported version of CEF.
Fixes #480
Motivation and Context
Generally, we aim to support the currently shipping CEF version and the previous (in this case 5060) to ensure easy verification of new issues with a current codebase (that is, easy downgrading for comparison), or to be able to easily revert in case of major bugs.
CefGetExitCode()did not exist until 124, and additional parameters were added toOnRenderProcessTerminated.How Has This Been Tested?
Toggle between CEF versions on Windows. Both compiled.
Types of changes
Checklist: