-
Notifications
You must be signed in to change notification settings - Fork 945
Moved department selection section to up #14628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Moved department selection section to up #14628
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
✅ Deploy Preview for care-ohc ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR reorganizes the encounter creation form by moving the department (organization) selection field to the top of the form, improving the logical flow of data entry. The change also includes visual refinements to spacing and layout.
- Moved the department selection field from the bottom to the top of the encounter form
- Adjusted spacing classes for better visual hierarchy
- Restructured the form submission buttons to use sticky positioning
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/pages/Facility/settings/organizations/components/FacilityOrganizationSelector.tsx | Reduced spacing from space-y-4 to space-y-3 for tighter visual grouping |
| src/components/Encounter/CreateEncounterForm.tsx | Relocated the organizations FormField to the top of the form, increased form spacing, adjusted sheet width, and refactored button container to use sticky positioning |
| </form> | ||
| </Form> | ||
| <div className="flex justify-end sticky -bottom-5 gap-2 bg-white py-5"> |
Copilot
AI
Dec 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The form closing tags are now positioned above the submit buttons, placing the buttons outside the form element. This breaks the form structure and will prevent the submit button from functioning correctly. The </form> and </Form> tags should remain after the button container to keep the buttons within the form.
| </div> | ||
| </form> | ||
| </Form> | ||
| <div className="flex justify-end sticky -bottom-5 gap-2 bg-white py-5"> |
Copilot
AI
Dec 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The negative bottom offset (-bottom-5) in sticky positioning appears unusual and may cause layout issues. Consider using bottom-0 instead, or if you need offset, verify this achieves the intended visual effect across different container heights.
| <div className="flex justify-end sticky -bottom-5 gap-2 bg-white py-5"> | |
| <div className="flex justify-end sticky bottom-0 gap-2 bg-white py-5"> |
🎭 Playwright Test ResultsStatus: ❌ Failed
📊 Detailed results are available in the playwright-final-report artifact. Run: #3032 |
Proposed Changes
Fixes #issue_number
Tagging: @ohcnetwork/care-fe-code-reviewers
Merge Checklist