Skip to content

Conversation

@NikhilA8606
Copy link
Member

Proposed Changes

Fixes #issue_number

  • Change 1
  • Change 2
  • Additional context if needed

Tagging: @ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate the bug or test the new feature.
  • Update product documentation.
  • Ensure that UI text is placed in I18n files.
  • Prepare a screenshot or demo video for the changelog entry and attach it to the issue.
  • Request peer reviews.
  • Complete QA on mobile devices.
  • Complete QA on desktop devices.
  • Add or update Playwright tests for related changes

Copilot AI review requested due to automatic review settings December 4, 2025 10:26
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 4, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@netlify
Copy link

netlify bot commented Dec 4, 2025

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 347aa8e
🔍 Latest deploy log https://app.netlify.com/projects/care-ohc/deploys/693161bd96de4d00084b6a6f
😎 Deploy Preview https://deploy-preview-14628.preview.ohc.network
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reorganizes the encounter creation form by moving the department (organization) selection field to the top of the form, improving the logical flow of data entry. The change also includes visual refinements to spacing and layout.

  • Moved the department selection field from the bottom to the top of the encounter form
  • Adjusted spacing classes for better visual hierarchy
  • Restructured the form submission buttons to use sticky positioning

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/pages/Facility/settings/organizations/components/FacilityOrganizationSelector.tsx Reduced spacing from space-y-4 to space-y-3 for tighter visual grouping
src/components/Encounter/CreateEncounterForm.tsx Relocated the organizations FormField to the top of the form, increased form spacing, adjusted sheet width, and refactored button container to use sticky positioning

Comment on lines 365 to +367
</form>
</Form>
<div className="flex justify-end sticky -bottom-5 gap-2 bg-white py-5">
Copy link

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The form closing tags are now positioned above the submit buttons, placing the buttons outside the form element. This breaks the form structure and will prevent the submit button from functioning correctly. The </form> and </Form> tags should remain after the button container to keep the buttons within the form.

Copilot uses AI. Check for mistakes.
</div>
</form>
</Form>
<div className="flex justify-end sticky -bottom-5 gap-2 bg-white py-5">
Copy link

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The negative bottom offset (-bottom-5) in sticky positioning appears unusual and may cause layout issues. Consider using bottom-0 instead, or if you need offset, verify this achieves the intended visual effect across different container heights.

Suggested change
<div className="flex justify-end sticky -bottom-5 gap-2 bg-white py-5">
<div className="flex justify-end sticky bottom-0 gap-2 bg-white py-5">

Copilot uses AI. Check for mistakes.
@github-actions
Copy link

github-actions bot commented Dec 4, 2025

🎭 Playwright Test Results

Status: ❌ Failed
Test Shards: 3

Metric Count
Total Tests 195
✅ Passed 193
❌ Failed 2
⏭️ Skipped 0

📊 Detailed results are available in the playwright-final-report artifact.

Run: #3032

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant