Skip to content

Conversation

@pmbrull
Copy link
Collaborator

@pmbrull pmbrull commented Dec 4, 2025

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Summary by Gitar

  • New regression tests:
    • Added test_standard_uuid_not_driver_license, test_salesforce_15_char_id_not_driver_license, and test_salesforce_18_char_id_not_driver_license in test_feature_extraction.py to prevent false positive PII classifications
  • Documentation cleanup:
    • Removed accidentally committed SDK development artifacts (SDK_COMPLETION_REPORT.md, SDK_COVERAGE_REPORT.md, etc.)

This will update automatically on new commits.


@gitar-bot
Copy link

gitar-bot bot commented Dec 4, 2025

Gitar Rules 🎸 1 action taken

Gitar Rules

🎸 PR Summary Enhancement: Summary already exists and is accurate; no action needed
Flaky Test Retry: All CI checks passed or skipped - no test failures detected
Rule Quality Standards: No Gitar rule markdown files added or modified in this PR
  • Auto-apply suggestions - Allow Gitar to commit updates to this branch

Was this helpful? React with 👍 / 👎 | This comment will update automatically (Docs)

@github-actions github-actions bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ingestion safe to test Add this label to run secure Github workflows on PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants