Conversation
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Yadunund <yadunund@openrobotics.org>
Signed-off-by: Yadunund <yadunund@openrobotics.org>
Signed-off-by: Yadunund <yadunund@openrobotics.org>
|
@mxgrey this is ready for review. There were some linker errors when compiling and hence I had to implement |
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
mxgrey
left a comment
There was a problem hiding this comment.
This is only a partial review with some comments of things that I think could be tweaked.
Overall this PR is looking good.
|
|
||
| //============================================================================== | ||
| /// Store contact details for telecommunication | ||
| class ContactCard |
There was a problem hiding this comment.
I don't see why this class would be in a detail namespace. If it gets touched by a user of the library then it should be in a normal public API namespace. If it doesn't get touched by a user of the library then we should keep it inside of src/ and we don't need to pimpl it.
| { | ||
| public: | ||
|
|
||
| struct PhoneNumber |
There was a problem hiding this comment.
We should pimpl this class if it's in the public API.
| const std::string& name, | ||
| const std::string& address, | ||
| const std::string& email, | ||
| PhoneNumber number); |
There was a problem hiding this comment.
I wonder if some of these fields should be optional. I suppose an empty string could imply that it's unknown, but I always prefer having the "null type" as an entirely separate object type for explicitness.
| using DescriptionPtr = std::shared_ptr<Description>; | ||
| using ConstDescriptionPtr = std::shared_ptr<const Description>; | ||
|
|
||
| class Model; |
There was a problem hiding this comment.
Instead of a custom Call::Model we can just use WaitFor::Description::make_model and return its result for Call::Description::make_model.
There was a problem hiding this comment.
Using WaitFor::Model for Call and SMS fb34755
|
|
||
| /// Make a PerformAction description. | ||
| /// | ||
| /// \param[in] action_name |
There was a problem hiding this comment.
Instead of an action name, I wonder if we should just accept an entire JSON payload to pass along to the command handle, and allow either side of the pipeline to do whatever they want with it.
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Yadunund <yadunund@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Yadunund <yadunund@openrobotics.org>
This PR adds Descriptions for items listed in #43