-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[receiver/kafka] Use max_fetch_size instead of default_fetch_size for franz-go consumer #44748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… franz-go consumer Signed-off-by: Paulo Dias <[email protected]>
Signed-off-by: Paulo Dias <[email protected]>
Member
Author
axw
reviewed
Dec 5, 2025
Contributor
axw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @paulojmdias, looks good - just a few things
Signed-off-by: Paulo Dias <[email protected]>
Signed-off-by: Paulo Dias <[email protected]>
Signed-off-by: Paulo Dias <[email protected]>
Signed-off-by: Paulo Dias <[email protected]>
Signed-off-by: Paulo Dias <[email protected]>
axw
approved these changes
Dec 8, 2025
Contributor
axw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks.
Contributor
|
Approved by codeowner, LGTM, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The franz-go Kafka consumer was using
default_fetch_size(a Sarama-specific setting) instead ofmax_fetch_sizewhen configuringkgo.FetchMaxBytes.This fix ensures the parameter
max_fetch_sizeis used and adds validation to prevent it from being less thanmin_fetch_size.The default value for
max_fetch_sizehas been changed from 0 (unlimited) to 1048576 (1 MiB) to maintain backward compatibility with the previous behavior. The default for franz-go is 50MiB.The
default_fetch_sizeparameter is now marked as deprecated for franz-go and will only be used with the legacy Sarama client.Link to tracking issue
Fixes #43104
Testing
Added tests to ensure
max_fetch_sizeis equal to or higher thanmin_fetch_size.Documentation
Updated documentation referring to the
default_fetch_sizeis deprecated.