-
Notifications
You must be signed in to change notification settings - Fork 1.6k
OBI docs: removes some deprecated configuration options and fixes some wrong OBI_ prefixes #8590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
grcevski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! LGTM!
tiffany76
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a few small copy edits!
| - `application`: Application-level metrics | ||
| - `application_host`: Application-level host metrics for host-based pricing. | ||
| - `application_span`: Application-level trace span metrics in legacy format | ||
| (like `traces_spanmetrics_latency`, `spanmetrics` is not separate). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can add this line to the front matter of this page. (I'd leave a suggestion there, but it's outside the commentable range.)
cSpell:ignore: spanmetrics
| The OBI metrics exporter can export the following metrics data groups for | ||
| processes matching entries in the [metrics discovery](./) configuration. | ||
|
|
||
| - `application`: Application-level metrics |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - `application`: Application-level metrics | |
| - `application`: Application-level metrics. |
| - `application`: Application-level metrics | ||
| - `application_host`: Application-level host metrics for host-based pricing. | ||
| - `application_span`: Application-level trace span metrics in legacy format | ||
| (like `traces_spanmetrics_latency`, `spanmetrics` is not separate). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| (like `traces_spanmetrics_latency`, `spanmetrics` is not separate). | |
| (like `traces_spanmetrics_latency`); `spanmetrics` is not separate. |
| - `application_span`: Application-level trace span metrics in legacy format | ||
| (like `traces_spanmetrics_latency`, `spanmetrics` is not separate). | ||
| - `application_span_otel`: Application-level trace span metrics in OpenTelemetry | ||
| format (like `traces_span_metrics_calls_total`), `span_metrics` is separate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| format (like `traces_span_metrics_calls_total`), `span_metrics` is separate. | |
| format (like `traces_span_metrics_calls_total`); `span_metrics` is separate. |
| [network metrics](../../network) configuration documentation to learn more | ||
| - `network_inter_zone`: Network inter-zone metrics, refer to the | ||
| [network metrics](../../network/) configuration documentation to learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| [network metrics](../../network) configuration documentation to learn more | |
| - `network_inter_zone`: Network inter-zone metrics, refer to the | |
| [network metrics](../../network/) configuration documentation to learn more | |
| [network metrics](../../network) configuration documentation to learn more. | |
| - `network_inter_zone`: Network inter-zone metrics, refer to the | |
| [network metrics](../../network/) configuration documentation to learn more. |
contribution guidelines,
including the First-time contributing? note.
the
Generative AI Contribution Policy.
Updates the documentation to some changes in OBI
metrics > featuresconfiguration section was added to OBI, and deprecated the per-exporter (OTEL or Prometheus) features section.OTEL_EBPF_ENABLE_CONTEXT_PROPAGATIONoption was totally removed from OBI but still some references to it persisted.OBI_prefix, but it should beOTEL_EBPF_