Fix Linux server deadlock on shutdown without TTY#1203
Open
TanF12 wants to merge 1 commit intoopenmultiplayer:masterfrom
Open
Fix Linux server deadlock on shutdown without TTY#1203TanF12 wants to merge 1 commit intoopenmultiplayer:masterfrom
TanF12 wants to merge 1 commit intoopenmultiplayer:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1201
This PR fixes the issue where the Linux server hangs during shutdown if started without a TTY (e.g. through nohup).
When running in background std::getline(std::wcin, line) fails because stdin is redirected/closed. The console thread exits gracefully early on. However, during shutdown, ~ConsoleComponent() blindly calls pthread_cancel() on the native thread handle, causing a deadlock or segfault because the thread is already dead.
My solution:
I've also:
My testing process: