-
Notifications
You must be signed in to change notification settings - Fork 77
OPRUN-4351: Update Dockerfiles/CI to use golang 1.25/ocp 4.22 #1178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@tmshort: This pull request references OPRUN-4351 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@tmshort: This pull request references OPRUN-4351 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest-required |
Signed-off-by: Todd Short <[email protected]>
Fix the cross-compilation issue without disabling CGO. The problem was that the macOS SDK 10.15 in the builder image doesn't have the SecTrustCopyCertificateChain symbol that Go 1.25's crypto/x509 package requires (this API was introduced in macOS 12.0). Use the -Wl,-undefined,dynamic_lookup linker flag for macOS cross-compilation. This tells the linker to allow undefined symbols that will be resolved at runtime. The alternative would be to disable CGO. Signed-off-by: Todd Short <[email protected]> Assisted by: Claude Code
oceanc80
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
rashmigottipati
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rashmigottipati, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@tmshort: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/label qe-approved |
|
@tmshort: This pull request references OPRUN-4351 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@bandrade: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Updates Docker files/CI to use golang 1.25/ocp 4.22
Fix the macos cross build within the OCP builder image
Fix the cross-compilation issue without disabling CGO. The problem was
that the macOS SDK 10.15 in the builder image doesn't have the
SecTrustCopyCertificateChain symbol that Go 1.25's crypto/x509 package
requires (this API was introduced in macOS 12.0).
Use the -Wl,-undefined,dynamic_lookup linker flag for macOS
cross-compilation. This tells the linker to allow undefined symbols
that will be resolved at runtime.
The alternative would be to disable CGO.