Skip to content

Conversation

@tmshort
Copy link
Contributor

@tmshort tmshort commented Dec 18, 2025

Updates Docker files/CI to use golang 1.25/ocp 4.22

Fix the macos cross build within the OCP builder image

Fix the cross-compilation issue without disabling CGO. The problem was
that the macOS SDK 10.15 in the builder image doesn't have the
SecTrustCopyCertificateChain symbol that Go 1.25's crypto/x509 package
requires (this API was introduced in macOS 12.0).

Use the -Wl,-undefined,dynamic_lookup linker flag for macOS
cross-compilation. This tells the linker to allow undefined symbols
that will be resolved at runtime.

The alternative would be to disable CGO.

@tmshort tmshort changed the title Update Dockerfiles/CI to use golang 1.25/ocp 4.22 OPRUN-4351: Update Dockerfiles/CI to use golang 1.25/ocp 4.22 Dec 18, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 18, 2025

@tmshort: This pull request references OPRUN-4351 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 18, 2025
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 18, 2025

@tmshort: This pull request references OPRUN-4351 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Updates Docker files/CI to use golang 1.25/ocp 4.22

Fix the macos cross build within the OCP builder image

Fix the cross-compilation issue without disabling CGO. The problem was
that the macOS SDK 10.15 in the builder image doesn't have the
SecTrustCopyCertificateChain symbol that Go 1.25's crypto/x509 package
requires (this API was introduced in macOS 12.0).

Use the -Wl,-undefined,dynamic_lookup linker flag for macOS
cross-compilation. This tells the linker to allow undefined symbols
that will be resolved at runtime.

The alternative would be to disable CGO.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rashmigottipati
Copy link
Member

/retest-required

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 18, 2025
Fix the cross-compilation issue without disabling CGO. The problem was
that the macOS SDK 10.15 in the builder image doesn't have the
SecTrustCopyCertificateChain symbol that Go 1.25's crypto/x509 package
requires (this API was introduced in macOS 12.0).

Use the -Wl,-undefined,dynamic_lookup linker flag for macOS
cross-compilation. This tells the linker to allow undefined symbols
that will be resolved at runtime.

The alternative would be to disable CGO.

Signed-off-by: Todd Short <[email protected]>
Assisted by: Claude Code
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 19, 2025
Copy link
Contributor

@oceanc80 oceanc80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2025
Copy link
Member

@rashmigottipati rashmigottipati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rashmigottipati, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 19, 2025

@tmshort: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-olm d6b2252 link true /test e2e-gcp-olm
ci/prow/unit-olm d6b2252 link true /test unit-olm
ci/prow/e2e-upgrade d6b2252 link true /test e2e-upgrade
ci/prow/unit-api d6b2252 link true /test unit-api

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bandrade
Copy link
Contributor

/label qe-approved
/verified by @bandrade

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Dec 19, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 19, 2025

@tmshort: This pull request references OPRUN-4351 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Updates Docker files/CI to use golang 1.25/ocp 4.22

Fix the macos cross build within the OCP builder image

Fix the cross-compilation issue without disabling CGO. The problem was
that the macOS SDK 10.15 in the builder image doesn't have the
SecTrustCopyCertificateChain symbol that Go 1.25's crypto/x509 package
requires (this API was introduced in macOS 12.0).

Use the -Wl,-undefined,dynamic_lookup linker flag for macOS
cross-compilation. This tells the linker to allow undefined symbols
that will be resolved at runtime.

The alternative would be to disable CGO.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Dec 19, 2025
@openshift-ci-robot
Copy link

@bandrade: This PR has been marked as verified by @bandrade.

Details

In response to this:

/label qe-approved
/verified by @bandrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 23e541f and 2 for PR HEAD d6b2252 in total

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants