Skip to content

Conversation

@somiaj
Copy link
Contributor

@somiaj somiaj commented Dec 13, 2025

PGML should use strong and emphasis for bold and italic. This also updates $BITALIC and $EITALIC in PGbasicmacros.pl to use emphasis. The $BBOLD and $EBOLD variables were already using strong, so this also makes things consistent.

PGML should use strong and emphasis for bold and italic. This
also updates `$BITALIC` and `$EITALIC` in PGbasicmacros.pl
to use emphasis. The `$BBOLD` and `$EBOLD` variables were already
using strong, so this also makes things consistent.
Copy link
Member

@drgrice1 drgrice1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I will let @dpvc weigh in though. Perhaps @Alex-Jordan as well if there is something wrong with this.

@Alex-Jordan
Copy link
Contributor

I already marked it as approved. I will go ahead and merge.

@Alex-Jordan
Copy link
Contributor

Or, I guess if @dpvc should weigh in on it, I will wait.

@drgrice1
Copy link
Member

I didn't look closely to see that you had already approved this.

@dpvc may not care too much on this issue. This is minor enough that we could probably go ahead and merge.

@dpvc
Copy link
Member

dpvc commented Dec 23, 2025

Sorry for not getting back to you on this. I have no objections.

@drgrice1 drgrice1 merged commit cf2cf3b into openwebwork:develop Dec 23, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants