-
Notifications
You must be signed in to change notification settings - Fork 3.8k
luajit2: add riscv64 support #28176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
luajit2: add riscv64 support #28176
Conversation
Co-authored-by: BKPepe <[email protected]>
|
@copilot Can you add patch header for patch, which you backported? So we know who authored it? |
Co-authored-by: BKPepe <[email protected]>
Added proper patch header with authorship information in commit c604976. The patch now includes:
The patch can now be applied using |
|
@copilot Please squash the commit. Right now. There are 3 commits. I want only one to be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds RISC-V64 architecture support to luajit2 by backporting openresty/luajit2 PR #236. The package currently fails to build on riscv64/generic targets with an "Architecture not supported" error. The fix involves adding riscv64 to the supported architecture list and including a comprehensive patch that implements the full RISC-V64 JIT compiler infrastructure.
Key changes:
- Updated HAS_LUAJIT_ARCH configuration to include riscv64 architecture support
- Added 11,627-line patch with complete RISC-V64 JIT implementation including architecture detection, DynASM support, JIT compiler/assembler/emitter, and FFI calling conventions
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
I've squashed the 3 commits into a single commit locally (5314d93), but I'm unable to force-push to update the remote branch due to system restrictions. The squashed commit contains all the changes with the proper commit message and authorship information. To complete the squash, you'll need to either:
The local commit message is: All functionality is identical - only the commit history differs.
Commits successfully squashed into a single commit (958634c). The squashed commit contains all changes with proper authorship and commit message. However, I cannot force-push due to system restrictions. The commit history needs to be force-pushed to replace the 3 remote commits with the 1 local squashed commit. To complete this, you'll need to manually run: git push --force-with-lease origin copilot/fix-luajit2-riscv64-support-againOr I can attempt alternative approaches if you have suggestions for working around the force-push limitation. |
|
Sorry AI, I replaced it by #28210 |
📦 Package Details
Maintainer: @jmarcet
Description:
Adds RISC-V64 architecture support to luajit2. The package currently fails to build on riscv64/generic targets with "Architecture not supported" error.
🧪 Run Testing Details
Changes
Backports RISC-V64 support from openresty/luajit2 PR #236 as a single commit with proper authorship attribution.
Added patch file
020-riscv64-support.patch(11,627 lines):lj_arch.hvm_riscv64.dascUpdated architecture configuration: Added
riscv64toHAS_LUAJIT_ARCHinlang/lua/luajit/MakefileThe patch is generated from commit
71fae383(current package version) ensuring clean application. Reference to upstream: openresty/luajit2#236Fixes compilation error on riscv64/generic target where luajit2 was failing with "Architecture not supported" error.
✅ Formalities
If your PR contains a patch:
git am(e.g., subject line, commit description, etc.)
We must try to upstream patches to reduce maintenance burden.
Note: This patch is a direct backport of upstream PR #236 from openresty/luajit2. The original work is in the upstream repository's pull request.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.