[FSSDK-12094] Fix Python holdout implementation which related to FSC failures #471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esrakartalOpt
changed the title
muzahidul-opti
left a comment
muzahidul-opti
left a comment
There was a problem hiding this comment.
Looks good to me. We need to figure out, how can we reuse Variation instead VariationDict
| - "3.10" | ||
| # disabled due to librt is not available on this pypy version | ||
| # - "pypy-3.9" | ||
| # - "pypy-3.10" |
There was a problem hiding this comment.
Couldn't we find a way to check with those versions?
Contributor
Author
There was a problem hiding this comment.
Disabled because of Matjaz's suggestion
optimizely/bucketer.py
Outdated
| experiment: Experiment, user_id: str, bucketing_id: str | ||
| ) -> tuple[Optional[Variation], list[str]]: | ||
| experiment: Experiment | Holdout, user_id: str, bucketing_id: str | ||
| ) -> tuple[Optional[Variation | VariationDict], list[str]]: |
There was a problem hiding this comment.
Why do we return VariationDict? Can we use Variation here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Issues