-
Notifications
You must be signed in to change notification settings - Fork 16
feat(config): Switch work order files from JSON to YAML #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
d795558 to
2ec1f03
Compare
aaronchongth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! Please also update the tests in https://github.com/osrf/nexus/tree/main/nexus_demos, which intakes the work orders
There is some flakiness in our integration testing CI at the moment, which is being looked into #115. You can run the tests locally too, by sourcing the workspace, navigating to the nexus_demos repository, and running RMW_IMPLEMENTATION=rmw_cyclonedds_cpp python3 -m unittest
Updated demo tests, configs, and dependencies to handle YAML format as per review.
|
Hi @aaronchongth, Apologies for the delay in getting these updates to you, and thanks again for the detailed review. I have now pushed the latest changes addressing all your feedback. Here is a quick summary of the work done:
The CI checks should all be passing now. Could you please take another look when you have a moment? Best, |
aaronchongth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes, I have left a few more comments.
We have not made the necessary changes to the github repository template yet, but could you also declare in your PR description if Generative AI tools were used for this PR, per OSRA policy https://discourse.openrobotics.org/t/osrf-adopts-policy-on-use-of-generative-ai-in-contributions/43685, and if so, what tool.
You can add and fill up this block
### GenAI Use
We follow [OSRA's policy on GenAI tools](https://github.com/openrobotics/osrf-policies-and-procedures/blob/main/OSRF%20Policy%20on%20the%20Use%20of%20Generative%20Tools%20(%E2%80%9CGenerative%20AI%E2%80%9D)%20in%20Contributions.md)
- [ ] I used a GenAI tool in this PR.
- [ ] I did not use GenAI
Generated-by:
| state: "state_1" | ||
|
No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| state: "state_1" | |
| state: "state_1" | |
EOF lines cannot have white spaces
| state: "state_1" | ||
|
No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| state: "state_1" | |
| state: "state_1" | |
EOF lines cannot have white spaces
| state: "state_1" | ||
|
No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| state: "state_1" | |
| state: "state_1" | |
EOF lines cannot have white spaces
nexus_demos/package.xml
Outdated
| <test_depend>ament_index_cpp</test_depend> | ||
| <test_depend>rcpputils</test_depend> | ||
|
|
||
| <!-- json2yaml edit --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove stale comment
|
Hi @aaronchongth, I've just pushed the latest updates addressing your feedback. The stale comments and extra whitespace have been removed from the YAML files, and I've also added the GenAI declaration to the pull request description. Could you please take another look when you have a moment? Thanks! |
Closes #86
This pull request migrates the work order description files from JSON to YAML format, as proposed in issue #86.
GenAI Use
We follow OSRA's policy on GenAI tools
Generated-by: Gemini 2.5 pro