Increase extensibility of BasicGraphicsScene and GraphicsView #492
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This is a general quality-of-life change that increases extensibility of the
BasicGraphicsSceneandGraphicsViewclasses.The rationale behind this is to enable users to do a few things:
BasicGraphicsSceneshould be able to override default event behavior. This is enabled by marking theon*methods as virtual.GraphicsViewclass. Enabling users to customize behavior when subclassing.setNodeGeometry()function has been added toBasicGraphicsScene, such that users can customize the defaultAbstractNodeGeometryused by theBasicGraphicsScene.Testing
Please fill out the sections above to help reviewers understand your changes.