Fix --extra-header argument not working#4
Open
szilard-dobai wants to merge 1 commit intopagedjs:mainfrom
Open
Conversation
Puppeteer expects to receive the extra HTTP headers as an object, not an array of objects.
--extra-header argument not working
Author
|
Hey there @fchasen! I was hoping you could take a look over this when you have a chance? I'm having some troubles setting up puppeteer to work for larger webpages when trying to print to PDF, but found this CLI works great. The only thing problem is the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Puppeteer expects to receive the extra HTTP headers as an object, not an array of objects.
Before this fix, trying to run the CLI with an
--extra-headerargument would throw with the following error:➜ pagedjs-cli http://www.google.com --extra-header xx:xx ◶ Loading: http://www.google.comfile:///Users/szilarddobai/.nvm/versions/node/v20.15.1/lib/node_modules/pagedjs-cli/node_modules/puppeteer-core/lib/esm/puppeteer/util/assert.js:25 throw new Error(message); ^ Error: Expected value of header "0" to be String, but "object" is found. at assert (file:///Users/szilarddobai/.nvm/versions/node/v20.15.1/lib/node_modules/pagedjs-cli/node_modules/puppeteer-core/lib/esm/puppeteer/util/assert.js:25:15) at NetworkManager.setExtraHTTPHeaders (file:///Users/szilarddobai/.nvm/versions/node/v20.15.1/lib/node_modules/pagedjs-cli/node_modules/puppeteer-core/lib/esm/puppeteer/common/NetworkManager.js:106:13) at CDPPage.setExtraHTTPHeaders (file:///Users/szilarddobai/.nvm/versions/node/v20.15.1/lib/node_modules/pagedjs-cli/node_modules/puppeteer-core/lib/esm/puppeteer/common/Page.js:448:50) at Printer.render (file:///Users/szilarddobai/.nvm/versions/node/v20.15.1/lib/node_modules/pagedjs-cli/src/printer.js:86:9) at process.processTicksAndRejections (node:internal/process/task_queues:95:5) at async Printer.pdf (file:///Users/szilarddobai/.nvm/versions/node/v20.15.1/lib/node_modules/pagedjs-cli/src/printer.js:270:14) at async file:///Users/szilarddobai/.nvm/versions/node/v20.15.1/lib/node_modules/pagedjs-cli/src/cli.js:172:10