-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat: add support for eth/70 eip-7975 #20255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
0xKarl98
wants to merge
39
commits into
paradigmxyz:main
Choose a base branch
from
0xKarl98:eth/70
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+680
−46
Open
Changes from all commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
7856d25
Add eth/70 protocol support and block range messaging
0xKarl98 70480ac
add comments
0xKarl98 3b129f5
fix tests
0xKarl98 13e9c00
touchups
0xKarl98 14453cc
add more comments to undertsand precisely
0xKarl98 dd7a10b
cargo fmt
0xKarl98 90492aa
keep eth/69 once enable full support
0xKarl98 63ac93a
instantiate based on message variant
0xKarl98 0d38ba9
optimize instant related code and remove test for now
0xKarl98 04824d3
cargo fmt
0xKarl98 f49b954
Throttle range requests using interval ticks
0xKarl98 c68bd50
simplify maybe_request_block_range and add comments
0xKarl98 19bdc02
chore: rerun CI
0xKarl98 39c725e
add eth/70 GetReceipts/Receipts message types and session wiring
0xKarl98 3e4e764
fix cargo doc
0xKarl98 b5ccdb8
remove unused import
0xKarl98 3b67d78
Add server-side support for eth/70 receipts pagination
0xKarl98 6d364b1
Reuse Receipts69 bloom helper for Receipts70
0xKarl98 2c70f51
remove block-range
0xKarl98 b7b3f32
address mattse suggestions
0xKarl98 d44a500
remove eth/70 block_range
0xKarl98 3f2f5ba
fix cargo doc
0xKarl98 c6628ae
fix test error
0xKarl98 f257508
remove unnessary last_range_update
0xKarl98 0b4d697
add manual encode for Receipts70
0xKarl98 d242059
apply mattese suggestions
0xKarl98 26db968
remove blockRangeUpdate from eth/70
0xKarl98 04d22f6
share eth/69 status with eth/70
0xKarl98 ed093cd
clean up
0xKarl98 35d214f
fix clippy
0xKarl98 b6d0e04
cargo fmt
0xKarl98 72bfdfe
remove unnessary macro
0xKarl98 fc8931c
remove unnessary macro
0xKarl98 5db0e51
restore max
0xKarl98 fd3b778
restore unnessary comment change
0xKarl98 6a4e5eb
remove unnessary import
0xKarl98 912ce28
cargo fmt
0xKarl98 3ab7774
restore unnessary session changes
0xKarl98 1af8a03
Delegating constraints to the method level
0xKarl98 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| 1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| {"schemaVersion":8,"wasmCacheVersion":"6.1.0-rc.3","plugins":{}} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should also use RequestPair and we can implement encode manually for Receipts70
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we have used RequestPair here , but the comment isn't clear , i.e. :
pub type Receipts70<T = Receipt> = crate::message::RequestPair<Receipts70Payload>;
Will make others misunderstood that we don't use RequestPair here but i wil simplify it