Update tests and correct dirtyState cloneResult

Author: tacxou

src/Mvc/Collection.php

@@ -198,8 +198,16 @@ public static function aggregate(?array $parameters = [], ?array $options = []):
      */
     public static function cloneResult(CollectionInterface $base, array $data, int $dirtyState = 0): CollectionInterface
     {
+        /**
+         * Clone the base record
+         */
         $collection = clone $base;
 
+        /**
+         * Mark the object as persistent
+         */
+        $collection->setDirtyState($dirtyState);
+
         foreach ($data as $key => $value) {
             $collection->writeAttribute($key, $value);
         }
@@ -1360,10 +1368,6 @@ protected static function getResultset(
             $base = $collection;
         }
 
-        if ($base instanceof self) {
-            $base->setDirtyState(self::DIRTY_STATE_PERSISTENT);
-        }
-
         $source = $collection->getSource();
         if (empty($source)) {
             throw new Exception("Method getSource() returns empty string");

tests/integration/Collection/CloneResultCest.php

@@ -62,6 +62,7 @@ public function mvcCollectionCloneResult(IntegrationTester $I)
         $robot = Robots::findFirst();
         $clonedRobot = Robots::cloneResult($robot, []);
 
+        $I->assertEquals(Robots::DIRTY_STATE_PERSISTENT, $clonedRobot->getDirtyState());
         $I->assertEquals($robot, $clonedRobot);
     }