Conversation
|
Why are all the /etc files for each php version removed? Looks like an oversight/mistake? |
|
I believe those are all common files moved to keel. |
febbraro
left a comment
febbraro
left a comment
There was a problem hiding this comment.
I haven't tested it, but it appears to have the right level of distinction between base CLI services and build container
|
While I did some basic testing of this, I did not use it on a real project. Should we publish temporary images and see if we can find folks to test this on a real project? |
The 5.5 image declared 5.6 in it's labels. All label declarations needed the comment about CentOS moved and a slash added to avoid syntax declaration errors trying to build.
|
I did a build and tested the PHP 5.6 image against a project (did a codebase build with it) and things seemed to go well. I pushed commit 8d33480 with things that I found that needed tweaking in order to allow me to build the images successfully and one typo that I found. Thumbs up from me on moving forward |
3 participants
It's possible the README could use some additional tuning.
Image Sizes
PHP Version | Before | After
-------------+---------+-------
php71 | 454 MB | ?
php70 | 453 MB | ?
php56 | 446 MB | ?
php55 | 453 MB | ?
Docker Hub has compressed image sizes, but from local builds I can only derive the full size.
Fixes #26