Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies the Dockerfile by replacing many COPY and wget instructions with bind mounts and ADD instructions to reduce image layers and residual files while adding checksum verifications.
- Replaces unnecessary COPY instructions with bind mounts.
- Replaces wget invocations for certificate retrieval with an ADD instruction using a checksum.
- Updates cleanup commands to target apt cache directories consistently.
📦 Container Size AnalysisComparing 📈 Size Comparison Table
|
Test Results 4 files ±0 4 suites ±0 1m 16s ⏱️ - 1m 12s For more details on these failures, see this check. Results for commit f761eb4. ± Comparison against base commit e21c90e. ♻️ This comment has been updated with latest results. |
🦙 MegaLinter status: ❌ ERROR
See detailed report in MegaLinter reports
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
📦 Container Size AnalysisComparing 📈 Size Comparison Table
|
| ADD --checksum=sha256:5e131007fad7c5f30d2f41090b49937fb8f16a787e5a95b4b3140e88d174dab2 \ | ||
| https://github.com/Jake-Shadle/xwin/releases/download/${XWIN_VERSION}/xwin-${XWIN_VERSION}-aarch64-unknown-linux-musl.tar.gz /xwin.tar.gz | ||
|
|
||
| FROM downloader-$TARGETARCH AS downloader |
Check warning
Code scanning / Trivy (MegaLinter REPOSITORY_TRIVY)
':latest' tag used Medium
| ARG DOCKER_VERSION | ||
| ARG XWIN_VERSION | ||
| ADD --checksum=sha256:53dc06dc3f775282ddff93b2d0974bbe6480761018c61e7a797342a9c7f14e23 \ | ||
| https://download.docker.com/linux/static/stable/x86_64/docker-${DOCKER_VERSION}.tgz /docker.tgz |
Check failure
Code scanning / Hadolint (MegaLinter DOCKERFILE_HADOLINT)
invalid flag: --checksum Error
Signed-off-by: Ron <45816308+rjaegers@users.noreply.github.com>
Signed-off-by: Ron <45816308+rjaegers@users.noreply.github.com>
Signed-off-by: Ron <45816308+rjaegers@users.noreply.github.com>
Signed-off-by: Ron <45816308+rjaegers@users.noreply.github.com>
|
|
This pull request is marked stale because it has been open for an extended period with no activity. Remove the 'stale' label or comment otherwise this pull request will be closed in 7 days. |
|
This pull request is marked stale because it has been open for an extended period with no activity. Remove the 'stale' label or comment otherwise this pull request will be closed in 7 days. |
|
This pull request is marked stale because it has been open for an extended period with no activity. Remove the 'stale' label or comment otherwise this pull request will be closed in 7 days. |
1 participant
🚀 Hey, I have created a Pull Request
Description of changes
This PR tries to replace all unnecessary COPY instructions with bind mounts, and all unnecessary wget invocations with ADD instructions. The intent is to reduce the number of layers and reduce any form of residue in the final image.
In the process add more checksums.
✔️ Checklist