Open
Conversation
add standart .gitignore from https://github.com/github/gitignore add .png to ignored formats.
Add .bak to gitignore Fix commas in pointLight.py
Workaround for None comprasion and __div__ operator
None swithed to `float('-inf')` for hit.entry and hit.exit.
Added `helpers.isninf` so `float('inf')` would not be mistaken for float('-inf').
`old_div` substituted for corresponding python3 division operators in USED code. import helpers changed to `from helpers import isninf` to lessen lenght of condition statements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
modified it to exclude
.pngand.bakfiles so repo would not be polluted by IDE or Editors byproducts and raycaster execution products;added
.ideadir for PyCharmNonecompassion forhit.etryandhit.exitby substitutingNonewithfloat('-inf');Modified condition statements;
helpers.isninfto avoid mistakingfloat('inf')forfloat('-inf')Note: Requires Pillow which is a PIL fork;
Also, could you create a separate branch for python3x or something so I could merge it there instead of
master?This repo is a good piece of code so I would like to keep it up to date with modern python, maybe someone else will use it for something.