A single DB connection instead of multiple connections #53
Open
colshrapnel wants to merge 1 commit intophpbridge:masterfrom
Open
A single DB connection instead of multiple connections #53colshrapnel wants to merge 1 commit intophpbridge:masterfrom
colshrapnel wants to merge 1 commit intophpbridge:masterfrom
Conversation
…ery class Connecting in every data class is a sure bad practice, and anyone who would try to extend the previously used approach to other classes will end up with tens of simultaneous connections to the database from the same PHP instance. So a database connection should be instantiated only once and then passed to all objects as a constructor parameter. Given this lesson is linked on the PHPTheRightWay, it shouldn't promote a bad practice, even for sake of simplification.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connecting in every data class is a sure bad practice, and anyone who would try to extend the previously used approach to other classes will end up with tens of simultaneous connections to the database from the same PHP instance.
So a database connection should be instantiated only once and then passed to all objects as a constructor parameter.
Given this lesson is linked on the PHPTheRightWay, it shouldn't promote a bad practice, even for sake of simplification.