Skip to content

pd: fix wrong description about inspect-network-interval#22416

Merged
ti-chi-bot[bot] merged 6 commits intopingcap:masterfrom
hfxsd:fix-wrong-description-in-pd-
Feb 6, 2026
Merged

pd: fix wrong description about inspect-network-interval#22416
ti-chi-bot[bot] merged 6 commits intopingcap:masterfrom
hfxsd:fix-wrong-description-in-pd-

Conversation

@hfxsd
Copy link
Collaborator

@hfxsd hfxsd commented Feb 6, 2026

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@hfxsd hfxsd self-assigned this Feb 6, 2026
@ti-chi-bot ti-chi-bot bot added contribution This PR is from a community contributor. missing-translation-status This PR does not have translation status info. labels Feb 6, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @hfxsd, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an inaccuracy in the documentation regarding the default state of slow-network node detection and scheduling within TiDB's PD component. It rectifies the information to correctly state that the feature is enabled by default and provides clearer guidance on how adjusting the inspect-network-interval parameter impacts system resources and detection speed.

Highlights

  • Documentation Correction: Corrected the documentation for slow-network node detection and scheduling, clarifying that this feature is enabled by default, not disabled.
  • Configuration Clarification: Updated the description for raftstore.inspect-network-interval to explain that a smaller value increases detection frequency but also consumes more network bandwidth and CPU resources.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • pd-control.md
    • Updated the introductory sentence for slow-network node detection to reflect that it is enabled by default.
    • Revised the explanation for raftstore.inspect-network-interval to detail the trade-offs between detection frequency and resource consumption.
Activity
  • The author, hfxsd, has signed the Contributor License Agreement.
  • The changes in this PR are applicable to the master branch and v8.5 versions.
  • This pull request is a translation from pingcap/docs-cn/pull/21330.
  • No human activity (comments, reviews) has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 6, 2026
@hfxsd hfxsd requested a review from okJiang February 6, 2026 09:07
@hfxsd hfxsd added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. and removed missing-translation-status This PR does not have translation status info. labels Feb 6, 2026
@hfxsd hfxsd changed the title pd: fix wrong description about inspect-network-interval pd: fix wrong description about inspect-network-interval Feb 6, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request corrects the description for slow-network node detection and scheduling. The change clarifies that network detection is enabled by default on TiKV and provides better guidance on tuning the inspect-network-interval parameter. I've suggested a small wording change to improve the clarity of the introductory sentence, which currently seems to contradict one of the configuration steps.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 6, 2026

@okJiang: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hfxsd hfxsd requested a review from qiancai February 6, 2026 09:21
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 6, 2026
@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 6, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-02-06 09:40:42.21479261 +0000 UTC m=+886.181969476: ☑️ agreed by qiancai.

Co-authored-by: Grace Cai <qqzczy@126.com>
@hfxsd hfxsd added the lgtm label Feb 6, 2026
@hfxsd
Copy link
Collaborator Author

hfxsd commented Feb 6, 2026

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 6, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Feb 6, 2026
@ti-chi-bot ti-chi-bot bot merged commit dbeacea into pingcap:master Feb 6, 2026
9 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #22421.
But this PR has conflicts, please resolve them!

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Feb 6, 2026
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved contribution This PR is from a community contributor. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants