-
Notifications
You must be signed in to change notification settings - Fork 870
DR-6723 Docs for TML-1663 and TML-1760 #7427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThese changes clarify that Prisma 7's mapped enum behavior has reverted to Prisma 6 semantics: TypeScript enums use schema names rather than mapped database values, with database-level mapping remaining intact. Documentation is updated across the core schema mapping reference and the v7 upgrade guide to reflect this behavior consistently. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related issues
Possibly related PRs
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
Dangerous URL checkNo absolute URLs to prisma.io/docs found. |
Redirect checkThis PR probably requires the following redirects to be added to static/_redirects:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
content/200-orm/800-more/300-upgrade-guides/200-upgrading-versions/400-upgrading-to-prisma-7.mdx (1)
402-426: Section heading inconsistency: "Before Prisma ORM v6" vs "In v6"There's a mismatch between the heading at line 402 ("Before Prisma ORM v6") and the explanatory text at line 414 ("In v6, the generated TypeScript enum was:"). The heading implies v5 and earlier, but the content actually describes v6 behavior.
Since the narrative is about the reversion to v6 semantics, consider renaming the heading to clarify:
📝 Suggested fix
-#### Before Prisma ORM v6 +#### Prisma ORM v6 (and now v7)Or alternatively, if you want to keep a "before/after" structure showing what was planned:
-#### Before Prisma ORM v6 +#### Prisma ORM v6 behavior
🧹 Nitpick comments (1)
content/200-orm/800-more/300-upgrade-guides/200-upgrading-versions/400-upgrading-to-prisma-7.mdx (1)
223-239: Consider adding npm overrides syntax alongside pnpm.The override example only shows the pnpm syntax. For npm users, the syntax is slightly different and lives at the top level of
package.json:📝 Suggested addition for npm users
```json { + // For npm: + "overrides": { + "better-sqlite3": "9.6.0" + }, + // For pnpm: "pnpm": { "overrides": { "better-sqlite3": "9.6.0" } } }</details> </blockquote></details> </blockquote></details> <details> <summary>📜 Review details</summary> **Configuration used**: Path: .coderabbit.yaml **Review profile**: CHILL **Plan**: Pro <details> <summary>📥 Commits</summary> Reviewing files that changed from the base of the PR and between 500e4726e2c8eace9e7d0e384d2e1f620ba93bd5 and 69819bfe1db067445a0dc6e0320631db5d517b51. </details> <details> <summary>📒 Files selected for processing (2)</summary> * `content/200-orm/100-prisma-schema/20-data-model/50-database-mapping.mdx` * `content/200-orm/800-more/300-upgrade-guides/200-upgrading-versions/400-upgrading-to-prisma-7.mdx` </details> <details> <summary>🧰 Additional context used</summary> <details> <summary>🧠 Learnings (1)</summary> <details> <summary>📚 Learning: 2026-01-06T22:06:57.725Z</summary>Learnt from: newclarityex
Repo: prisma/docs PR: 7425
File: content/200-orm/050-overview/500-databases/400-mysql.mdx:80-80
Timestamp: 2026-01-06T22:06:57.725Z
Learning: In Prisma docs, when showing examples of instantiating driver adapters with connection strings from environment variables, use the template literal patternconst connectionString =${process.env.DATABASE_URL}`` for consistency across all database adapter examples (PostgreSQL, MySQL/MariaDB, etc.).**Applied to files:** - `content/200-orm/100-prisma-schema/20-data-model/50-database-mapping.mdx` - `content/200-orm/800-more/300-upgrade-guides/200-upgrading-versions/400-upgrading-to-prisma-7.mdx` </details> </details> </details> <details> <summary>⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)</summary> * GitHub Check: Check internal links * GitHub Check: Cloudflare Pages </details> <details> <summary>🔇 Additional comments (2)</summary><blockquote> <details> <summary>content/200-orm/100-prisma-schema/20-data-model/50-database-mapping.mdx (1)</summary><blockquote> `81-101`: **Documentation updates look accurate and well-aligned with the reverted behavior.** The changes correctly reflect that: 1. TypeScript enums use schema names (`PENDING`, `APPROVED`) rather than mapped database values 2. The `@map` directive only affects the database layer The example is clear, and removing the version-specific qualifier from the heading is appropriate since this behavior now applies consistently. This aligns well with the corresponding upgrade guide changes. </blockquote></details> <details> <summary>content/200-orm/800-more/300-upgrade-guides/200-upgrading-versions/400-upgrading-to-prisma-7.mdx (1)</summary><blockquote> `394-400`: **Clear communication of the reverted behavior.** The note block explaining the reversion is helpful, and the migration steps section correctly informs users that no action is needed. This should reduce confusion for developers upgrading from v6 who might have been expecting breaking changes in enum handling. The statement "The mapping is handled at the database level only" is consistent with the database-mapping.mdx file, maintaining good documentation coherence across the docs. Also applies to: 436-440 </blockquote></details> </blockquote></details> </details> <!-- This is an auto-generated comment by CodeRabbit for review status -->
Deploying docs with
|
| Latest commit: |
69819bf
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://36247201.docs-51g.pages.dev |
| Branch Preview URL: | https://dr-6723-docs-for-tml-1663-an.docs-51g.pages.dev |
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.