[kube-prometheus-stack] Pass through Thanos configuration #6281
+6
−64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anes Belfodil <[email protected]>
abelfodil
requested review from
GMartinez-Sisti,
QuentinBisson,
Xtigyro,
andrewgkew,
gianrubio,
gkarthiks,
jkroepke and
scottrigby
as code owners
Member
|
Hm, it feels like just breaking things. (No Secret anymore) |
Contributor
Author
|
I don't see the need of defining the secret through the chart. It's not an object from CRD, so people can define theirs separately and reference it. If people really want to define a secret through the chart, they can use While it does break things indeed, it also opens more opportunities for customization. |
Member
|
Hm. I say that more opportunities are possible, without breaking existing things. |
jkroepke
requested changes
Oct 31, 2025
Member
jkroepke
left a comment
jkroepke
left a comment
There was a problem hiding this comment.
please add some backwards compatibility.
Contributor
Author
|
Ack |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Pass through Thanos configuration instead of recreating every field manually. This would stabilize the feature as it would follow https://github.com/prometheus-operator/prometheus-operator/blob/main/Documentation/api-reference/api.md#thanosspec 1:1.
Which issue this PR fixes
None
Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])