Remove unused scraper #1790
Open
Remove unused scraper #1790
+0
−842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jeschkies <[email protected]>
jeschkies
force-pushed
the
karsten/remove-unused-scraper
branch
from
bcde478 to
9b08e8d
Compare
Contributor
|
Hi @jeschkies 👋 This code was included in the last release. This PR will remove the mentioned methods from the library API; therefore, it will be a breaking change. It is possible to check whether these methods/types are used in this project; however, some of them are exported so they can be used programmatically (as a library) by other projects. At the same time, there is no major version release yet, so we can consider this change if we have a good reason to remove this functionality. @cristiangreco, what is your opinion on that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes unused code.